Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "includes paid promotion" links from thumbnails. #2423

Open
Daygath opened this issue Jun 29, 2024 · 8 comments
Open

Remove "includes paid promotion" links from thumbnails. #2423

Daygath opened this issue Jun 29, 2024 · 8 comments
Labels
Completition / Revision Rethink, complete, improve, tweak our feature or structure. Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@Daygath
Copy link

Daygath commented Jun 29, 2024

PROBLEM:

I frequently accidentally click on the utterly worthless "includes paid promotion" links on thumbnails when trying to play a video or open it in a new tab. It is a dumb and pointless feature as it's expected that videos will include paid promotion.

SOLUTION:

Removed YouTube's pointless addition of the link.

ALTERNATIVES:

None

RELEVANCE / SCOPE:

Estimate how many percent of our users (or all youtube users) should/would use your idea? All? I can't be alone on this.

"SIDE EFFECTS":

Who might NOT want this? Whomever created the feature?

CONTEXT:
//
Thank you!

SHORT Table (Summary)
Problem
Solution
Alternatives
Scope
Side effects
Context
@Daygath Daygath added Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Jun 29, 2024
@raszpl
Copy link
Contributor

raszpl commented Jun 29, 2024

Are you saying "includes paid promotion" is a link to YT information page? I cant find an example right now, can you link one?
How about making it pass thru so its still visible, but clicking on it doesnt redirect to stupid places and instead clicks on the thumbnail like intended?

@Daygath
Copy link
Author

Daygath commented Jun 30, 2024

Here is the link it sends me to. Given your response, it sounds like I might be part of an A/B test or it's regional.
https://support.google.com/youtube/answer/10588440?nohelpkit=1&p=ppp&rd=1

@Daygath
Copy link
Author

Daygath commented Jun 30, 2024

This is a screen shot from my subscription page.
Untitled

@raszpl
Copy link
Contributor

raszpl commented Jul 1, 2024

I searched for Sabine AI passed the Turing Test -- And No One Noticed video and I get live preview thumbnail for it without that paid promotion banner :| thats logged in Chrome.

But I do same thing in FF logged out and I do see it:

<div class="YtInlinePlayerControlsTopLeftControls"><ytm-paid-content-overlay-renderer class="YtmPaidContentOverlayHost YtmPaidContentOverlayHidden"><a class="YtmPaidContentOverlayLink" href="https://support.google.com/youtube?p=ppp&amp;nohelpkit=1"> ... </a></ytm-paid-content-overlay-renderer></div>

What we are interested in
<div class="YtInlinePlayerControlsTopLeftControls"></div>

adding CSS pointer-events: none; will make it pass clicks to main video, adding left: 34px; will stop it from covering Blocklist icon

we Do have hide_thumbnail_overlay "Hide buttons on thumbnails" that in theory sounds like it should cover this case, but it doesnt work because ... drum roll .. it doesnt exist :O there is no hideThumbnailOverlay function in the code :] argh, its one of those CSS only settings

html[it-hide-thumbnail-overlay='true'] #hover-overlays,

and it doesnt cover video-preview

Found another annoyance: looks like popup_window_buttons "Add a popup-player-button to each thumbnail" popupWindowButtons is only half implemented, can turn it on, but turning it off doesnt remove the button until page reload :(

@Daygath
Copy link
Author

Daygath commented Jul 1, 2024

I suppose I should add that I'm using the FF fork LibreWolf. I am logged into YouTube, but I do block tracking.

@Daygath
Copy link
Author

Daygath commented Jul 1, 2024

Oh, and I have YT Premium.

@raszpl
Copy link
Contributor

raszpl commented Jul 1, 2024

#2432 makes HIDE BUTTONS ON THUMBNAILS also affect those "includes paid promotion" banners. Additionally turning on Blocklist will move them to the right of video-preview.

@ImprovedTube
Copy link
Member

#2432 makes HIDE BUTTONS ON THUMBNAILS also affect

chance are @Daygath and other people want to hide it or make it much smaller,
but keep the other buttons. (- And we may figure out betters way to find / navigate another 100 (or 1000) little/rare features:
#2251 ..)

@ImprovedTube ImprovedTube added the Completition / Revision Rethink, complete, improve, tweak our feature or structure. label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completition / Revision Rethink, complete, improve, tweak our feature or structure. Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

3 participants