Support a @trim directive when patching GraphQL schema (#485)

Author: miorel

workspaces/leetcode-api/schema-patched.graphql

@@ -18,6 +18,7 @@ import {
 type DirectivesConfig = {
   nonnegative?: boolean;
   slug?: boolean;
+  trim?: boolean;
   enumValues?: string[];
 };
 
@@ -49,6 +50,11 @@ function parseDirectives(
         res.slug = true;
         break;
       }
+      case "trim": {
+        invariant(!directive.arguments?.length, "No arguments allowed!");
+        res.trim = true;
+        break;
+      }
       default: {
         throw new Error("Unsupported directive " + directive.name.value);
       }
@@ -91,10 +97,7 @@ function generateZod(
       }
       case "Int": {
         const { nonnegative, ...rest } = parseDirectives(directives);
-        invariant(
-          Object.values(rest).every((v) => v === false),
-          "Unsupported directives!",
-        );
+        invariant(Object.keys(rest).length === 0, "Unsupported directives!");
 
         return [
           new ZodOutput(
@@ -120,28 +123,29 @@ function generateZod(
         return [new ZodOutput("z.string()", true), []];
       }
       case "String": {
-        const { slug, enumValues, ...rest } = parseDirectives(directives);
-        invariant(!(slug && enumValues), "Incompatible directive combination!");
-        invariant(
-          Object.values(rest).every((v) => v === false),
-          "Unsupported directives!",
-        );
+        const { slug, trim, enumValues, ...rest } = parseDirectives(directives);
+        invariant(Object.keys(rest).length === 0, "Unsupported directives!");
 
         if (enumValues) {
+          invariant(!slug && !trim, "Incompatible directive combination!");
           return [
             new ZodOutput(`z.enum(${JSON.stringify(enumValues)})`, true),
             [],
           ];
         }
 
         if (slug) {
+          invariant(!trim, "@trim is redundant when @slug is enabled!");
           return [
             new ZodOutput("slugZodType", true),
             ['import { slugZodType } from "../../zod-types/slugZodType.ts"'],
           ];
         }
 
-        return [new ZodOutput("z.string()", true), []];
+        return [
+          new ZodOutput(["z.string()", trim ? ".trim()" : ""].join(""), true),
+          [],
+        ];
       }
       default: {
         throw new Error("Unsupported scalar type: " + currentType.name);

workspaces/leetcode-api/src/api/active-daily-coding-challenge-question/fetchGraphQL.generated.ts

@@ -9,7 +9,7 @@ import { nameNode } from "./astNodeBuilders.ts";
 
 // TODO: keep in sync with DirectivesConfig in graphqlToZod
 
-export const CUSTOM_DIRECTIVES = ["nonnegative", "slug"] as const;
+export const CUSTOM_DIRECTIVES = ["nonnegative", "slug", "trim"] as const;
 
 // TODO: memoize by directiveName?
 

workspaces/leetcode-api/src/api/question-list/fetchGraphQL.generated.ts

@@ -68,14 +68,15 @@ export const FIELD_MODIFICATIONS: SafeObjectMap<
     solutionNum: [markNonNull, addDirective("nonnegative")],
     stats: [markNonNull],
     submitUrl: [markNonNull],
+    title: [addDirective("trim")],
     titleSlug: [addDirective("slug")],
     topicTags: [markNonNull],
     urlManager: [markNonNull],
   },
   SubmissionDumpNode: {
     id: [markNonNull],
     timestamp: [markNonNull],
-    title: [markNonNull],
+    title: [markNonNull, addDirective("trim")],
     titleSlug: [markNonNull, addDirective("slug")],
   },
 };