esm

Author: miorel

.yarn/patches/nullthrows-npm-1.1.1-3d1f817134.patch

@@ -10,7 +10,7 @@ index d4953f2f47b79701e5f125b9c041fb185668dd53..5c48891acb35ca7ac8a3393e54cd89a1
 +  value?: T | null,
 +  message?: string,
 +): NonNullable<T>;
-
+ 
 -export default function nullthrows<T>(value?: T | null, message?: string): T;
 +// Patched based on https://github.com/microsoft/TypeScript/issues/46770#issuecomment-1039459991 and https://github.com/zertosh/nullthrows/pull/15
 +

package.json

@@ -18,6 +18,7 @@
     "workspaces/repository-scripts",
     "workspaces/util"
   ],
+  "type": "module",
   "scripts": {
     "format": "yarn workspace @code-chronicles/repository-scripts start format",
     "lint": "yarn workspace @code-chronicles/repository-scripts start lint",

workspaces/adventure-pack/goodies/typescript/Iterator.prototype.drop/index.ts

@@ -1,4 +1,4 @@
-import "../Iterator.prototype.toIterable";
+import "../Iterator.prototype.toIterable/index.ts";
 import { iteratorPrototype } from "../Iterator.prototype/index.ts";
 
 declare global {

workspaces/adventure-pack/package.json

@@ -50,7 +50,7 @@
     "goodies:typescript:test": "jest --color \"/goodies/typescript/\"",
     "build-app": "tsx src/scripts/build/main.ts",
     "build-chrome-extension": "tsx src/scripts/build/buildChromeExtension.ts",
-    "package-goodies:test": "jest --color --testPathIgnorePatterns=\"<rootDir>/goodies/\"",
+    "package-goodies:test": "cross-env NODE_OPTIONS=\"--experimental-vm-modules\" jest --color --testPathIgnorePatterns=\"<rootDir>/goodies/\"",
     "format": "yarn goodies:java:format && yarn goodies:kotlin:format && yarn goodies:python3:format && yarn goodies:typescript:format && prettier --color --write .",
     "lint": "eslint --color --max-warnings=0 .",
     "postinstall": "yarn goodies:java:install && yarn goodies:kotlin:install && yarn goodies:python3:install",
@@ -73,6 +73,7 @@
     "@types/react": "18.3.5",
     "@types/react-dom": "18.3.0",
     "@types/react-syntax-highlighter": "15.5.13",
+    "cross-env": "7.0.3",
     "eslint": "9.10.0",
     "jest": "29.7.0",
     "prettier": "3.3.3",

workspaces/adventure-pack/src/app/__tests__/__snapshots__/equip-test.ts.snap

@@ -2061,17 +2061,18 @@ exports[`App can equip single goody: JavaScript Map.groupBy 1`] = `
 
 Map.groupBy ??= function (iterable, callbackFn) {
   const groups = new Map();
+
   let index = 0;
   for (const value of iterable) {
-    const key = callbackFn(value, index);
+    const key = callbackFn(value, index++);
     const group = groups.get(key);
     if (group == null) {
       groups.set(key, [value]);
     } else {
       group.push(value);
     }
-    ++index;
   }
+
   return groups;
 };
 
@@ -4391,17 +4392,18 @@ Map.groupBy ??= function <K, V>(
   callbackFn: (value: V, index: number) => K,
 ): Map<K, V[]> {
   const groups = new Map<K, V[]>();
+
   let index = 0;
   for (const value of iterable) {
-    const key = callbackFn(value, index);
+    const key = callbackFn(value, index++);
     const group = groups.get(key);
     if (group == null) {
       groups.set(key, [value]);
     } else {
       group.push(value);
     }
-    ++index;
   }
+
   return groups;
 };
 

workspaces/adventure-pack/src/app/__tests__/__snapshots__/render-test.ts.snap

@@ -1128,17 +1128,18 @@ iteratorPrototype.toSet ??= function () {
 exports[`App can render goody: JavaScript Map.groupBy 1`] = `
 "Map.groupBy ??= function (iterable, callbackFn) {
   const groups = new Map();
+
   let index = 0;
   for (const value of iterable) {
-    const key = callbackFn(value, index);
+    const key = callbackFn(value, index++);
     const group = groups.get(key);
     if (group == null) {
       groups.set(key, [value]);
     } else {
       group.push(value);
     }
-    ++index;
   }
+
   return groups;
 };"
 `;
@@ -2506,17 +2507,18 @@ Map.groupBy ??= function <K, V>(
   callbackFn: (value: V, index: number) => K,
 ): Map<K, V[]> {
   const groups = new Map<K, V[]>();
+
   let index = 0;
   for (const value of iterable) {
-    const key = callbackFn(value, index);
+    const key = callbackFn(value, index++);
     const group = groups.get(key);
     if (group == null) {
       groups.set(key, [value]);
     } else {
       group.push(value);
     }
-    ++index;
   }
+
   return groups;
 };"
 `;

workspaces/adventure-pack/src/app/components/App.tsx

@@ -9,6 +9,8 @@ import { useAppState } from "../useAppState.ts";
 import type { Goody } from "../Goody.ts";
 import { LanguageSelector } from "./LanguageSelector.tsx";
 
+// TODO: add a lint rule that files are imported with their actual extension (i.e. ".tsx" not ".ts" where applicable)
+
 function Column({
   children,
   flex,

workspaces/adventure-pack/src/app/stringifyTypeScriptModuleDeclarations.ts

@@ -5,6 +5,8 @@ import { isStringEmptyOrWhitespaceOnly } from "@code-chronicles/util/isStringEmp
 import type { GoodyModuleDeclaration } from "../scripts/package-goodies/typescript/extractModuleDeclarations.ts";
 import { stringifyTypeScriptInterfaceDeclarations } from "./stringifyTypeScriptInterfaceDeclarations.ts";
 
+// TODO: we should probably not allow impoting stuff from the scripts, even if it's just the type
+
 const INDENT = "  ";
 
 export function stringifyTypeScriptModuleDeclarations(

workspaces/adventure-pack/src/app/useAppState.ts

@@ -1,5 +1,5 @@
 import immutableUpdate from "immutability-helper";
-import { useReducer, type Dispatch as ReactDispatch } from "react";
+import { type Dispatch as ReactDispatch, useReducer } from "react";
 
 import type { GoodiesByLanguage } from "./fetchGoodies.ts";
 import type { Language } from "./Language.ts";

workspaces/adventure-pack/src/scripts/package-goodies/typescript/formatCode.ts

@@ -1,4 +1,4 @@
-import * as prettier from "prettier";
+import prettier from "prettier";
 
 export function formatCode(code: string): Promise<string> {
   return prettier.format(code, { parser: "typescript" });