Test Sentry call correctly

Author: joshsmith

config/config.exs

@@ -82,6 +82,8 @@ config :sentry,
   included_environments: ~w(prod staging)a,
   use_error_logger: true
 
+config :code_corps, :sentry, CodeCorps.Sentry.Async
+
 config :code_corps, :processor, CodeCorps.Processor.Async
 
 # Import environment specific config. This must remain at the bottom

config/test.exs

@@ -57,6 +57,8 @@ config :code_corps,
 config :sentry,
   environment_name: Mix.env || :test
 
+config :code_corps, :sentry, CodeCorps.Sentry.Sync
+
 config :code_corps, :processor, CodeCorps.Processor.Sync
 
 config :code_corps, CodeCorps.Mailer,

lib/code_corps/github/event.ex

@@ -45,7 +45,7 @@ defmodule CodeCorps.GitHub.Event do
   end
   def stop_processing({:error, reason, error}, %GithubEvent{} = event) do
     %GitHubEventError{reason: error}
-    |> Sentry.capture_exception([stacktrace: System.stacktrace()])
+    |> CodeCorps.Sentry.capture_exception([stacktrace: System.stacktrace()])
 
     changes = %{
       status: "errored",

lib/code_corps/sentry/async.ex

@@ -0,0 +1,6 @@
+defmodule CodeCorps.Sentry.Async do
+  def capture_exception(exception, opts \\ []) do
+    exception
+    |> Sentry.capture_exception(opts)
+  end
+end

lib/code_corps/sentry/sentry.ex

@@ -0,0 +1,7 @@
+defmodule CodeCorps.Sentry do
+  @sentry Application.get_env(:code_corps, :sentry)
+
+  def capture_exception(exception, opts \\ []) do
+    @sentry.capture_exception(exception, opts)
+  end
+end

lib/code_corps/sentry/sync.ex

@@ -0,0 +1,6 @@
+defmodule CodeCorps.Sentry.Sync do
+  def capture_exception(exception, opts \\ []) do
+    exception
+    |> Sentry.capture_exception(opts |> Keyword.put(:result, :sync))
+  end
+end

test/lib/code_corps/github/webhook/handler_test.exs

@@ -264,13 +264,14 @@ defmodule CodeCorps.GitHub.Webhook.HandlerTest do
       bypass = Bypass.open
       Bypass.expect bypass, fn conn ->
         {:ok, body, conn} = Plug.Conn.read_body(conn)
-        assert body =~ "RuntimeError"
-        assert body =~ "ExampleApp"
+        assert body =~ "GitHubEventError"
+        assert body =~ "CodeCorps"
         assert conn.request_path == "/api/1/store/"
         assert conn.method == "POST"
         Plug.Conn.resp(conn, 200, ~s<{"id": "340"}>)
       end
 
+      modify_env(:sentry, environment_name: :prod)
       modify_env(:sentry, dsn: "http://public:secret@localhost:#{bypass.port}/1")
 
       {:ok, %GithubEvent{} = event} = Handler.handle_supported("issues", "abc-456", edited_payload)