Added task close tracking

Author: begedin

lib/code_corps_web/controllers/task_controller.ex

@@ -46,6 +46,7 @@ defmodule CodeCorpsWeb.TaskController do
       current_user |> maybe_track_connected(updated_task, task)
       current_user |> maybe_track_list_move(updated_task, task)
       current_user |> maybe_track_title_change(updated_task, task)
+      current_user |> maybe_track_close(updated_task, task)
 
       conn |> render("show.json-api", data: updated_task)
     end
@@ -102,4 +103,14 @@ defmodule CodeCorpsWeb.TaskController do
     user_id |> SegmentTracker.track("Edited Task Title", task)
   end
   defp maybe_track_title_change(%User{}, %Task{}, %Task{}), do: :nothing
+
+  @spec maybe_track_close(User.t, Task.t, Task.t) :: any
+  defp maybe_track_close(
+    %User{id: user_id},
+    %Task{status: "closed"} = task,
+    %Task{status: "open"}) do
+
+    user_id |> SegmentTracker.track("Closed Task", task)
+  end
+  defp maybe_track_close(%User{}, %Task{}, %Task{}), do: :nothing
 end

test/lib/code_corps_web/controllers/task_controller_test.exs

@@ -243,6 +243,27 @@ defmodule CodeCorpsWeb.TaskControllerTest do
       refute_received {:track, ^user_id, "Edited Task Title", _}
     end
 
+    @tag :authenticated
+    test "tracks closing task", %{conn: conn, current_user: current_user} do
+      task = insert(:task, user: current_user, status: "open")
+      attrs = @valid_attrs |> Map.put(:status, "closed")
+      conn |> request_update(task, attrs)
+
+      traits = Task |> Repo.get(task.id) |> SegmentTraitsBuilder.build
+      user_id = current_user.id
+      assert_received {:track, ^user_id, "Closed Task", ^traits}
+    end
+
+    @tag :authenticated
+    test "does not track closing task if no close took place", %{conn: conn, current_user: current_user} do
+      task = insert(:task, user: current_user, status: "open")
+      attrs = @valid_attrs |> Map.delete(:status)
+      conn |> request_update(task, attrs)
+
+      user_id = current_user.id
+      refute_received {:track, ^user_id, "Closed Task", _}
+    end
+
     @tag :authenticated
     test "renders 422 when data is invalid", %{conn: conn, current_user: current_user} do
       task = insert(:task, user: current_user)