Skip to content

Commit ac78457

Browse files
committed
Rename actions
1 parent 84ac192 commit ac78457

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

lib/code_corps_web/controllers/github_app_installation_controller.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,6 @@ defmodule CodeCorpsWeb.GithubAppInstallationController do
3737

3838
@spec track_created(User.t, GithubAppInstallation.t) :: any
3939
defp track_created(%User{id: user_id}, %GithubAppInstallation{} = installation) do
40-
user_id |> SegmentTracker.track("Created GithubAppInstallation", installation)
40+
user_id |> SegmentTracker.track("Created GitHub App Installation", installation)
4141
end
4242
end

lib/code_corps_web/controllers/project_github_repo_controller.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,11 @@ defmodule CodeCorpsWeb.ProjectGithubRepoController do
5555

5656
@spec track_created(User.t, ProjectGithubRepo.t) :: any
5757
defp track_created(%User{id: user_id}, %ProjectGithubRepo{} = project_github_repo) do
58-
user_id |> SegmentTracker.track("Added ProjectGithubRepo", project_github_repo)
58+
user_id |> SegmentTracker.track("Connected GitHub Repo to Project", project_github_repo)
5959
end
6060

6161
@spec track_deleted(User.t, ProjectGithubRepo.t) :: any
6262
defp track_deleted(%User{id: user_id}, %ProjectGithubRepo{} = project_github_repo) do
63-
user_id |> SegmentTracker.track("Removed ProjectGithubRepo", project_github_repo)
63+
user_id |> SegmentTracker.track("Disconnected GitHub Repo from Project", project_github_repo)
6464
end
6565
end

lib/code_corps_web/controllers/project_skill_controller.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ defmodule CodeCorpsWeb.ProjectSkillController do
2828
{:ok, :authorized} <- current_user |> Policy.authorize(:create, %ProjectSkill{}, params),
2929
{:ok, %ProjectSkill{} = project_skill} <- %ProjectSkill{} |> ProjectSkill.create_changeset(params) |> Repo.insert do
3030

31-
current_user.id |> SegmentTracker.track("Added ProjectSkill", project_skill)
31+
current_user.id |> SegmentTracker.track("Added Project Skill", project_skill)
3232
conn |> put_status(:created) |> render("show.json-api", data: project_skill)
3333
end
3434
end
@@ -40,7 +40,7 @@ defmodule CodeCorpsWeb.ProjectSkillController do
4040
{:ok, :authorized} <- current_user |> Policy.authorize(:delete, project_skill),
4141
{:ok, %ProjectSkill{} = project_skill} <- project_skill |> Repo.delete
4242
do
43-
current_user.id |> SegmentTracker.track("Removed ProjectSkill", project_skill)
43+
current_user.id |> SegmentTracker.track("Removed Project Skill", project_skill)
4444
conn |> Conn.assign(:project_skill, project_skill) |> send_resp(:no_content, "")
4545
end
4646
end

test/lib/code_corps_web/controllers/github_app_installation_controller_test.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ defmodule CodeCorpsWeb.GithubAppInstallationControllerTest do
6161

6262
user_id = current_user.id
6363
traits = GithubAppInstallation |> Repo.one |> SegmentTraitsBuilder.build
64-
assert_receive({:track, ^user_id, "Created GithubAppInstallation", ^traits})
64+
assert_receive({:track, ^user_id, "Created GitHub App Installation", ^traits})
6565
end
6666

6767
@tag :authenticated

test/lib/code_corps_web/controllers/project_github_repo_controller_test.exs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ defmodule CodeCorpsWeb.ProjectGithubRepoControllerTest do
6565
user_id = current_user.id
6666
traits = ProjectGithubRepo |> Repo.one |> SegmentTraitsBuilder.build
6767

68-
assert_receive({:track, ^user_id, "Added ProjectGithubRepo", ^traits})
68+
assert_receive({:track, ^user_id, "Connected GitHub Repo to Project", ^traits})
6969
end
7070

7171
@tag :authenticated
@@ -107,7 +107,7 @@ defmodule CodeCorpsWeb.ProjectGithubRepoControllerTest do
107107
user_id = current_user.id
108108
traits = project_github_repo |> SegmentTraitsBuilder.build
109109

110-
assert_receive({:track, ^user_id, "Removed ProjectGithubRepo", ^traits})
110+
assert_receive({:track, ^user_id, "Disconnected GitHub Repo from Project", ^traits})
111111
end
112112

113113
test "renders 401 when unauthenticated", %{conn: conn} do

test/lib/code_corps_web/controllers/project_skill_controller_test.exs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ defmodule CodeCorpsWeb.ProjectSkillControllerTest do
6565
user_id = current_user.id
6666
traits = ProjectSkill |> Repo.one |> SegmentTraitsBuilder.build
6767

68-
assert_received({:track, ^user_id, "Added ProjectSkill", ^traits})
68+
assert_received({:track, ^user_id, "Added Project Skill", ^traits})
6969
end
7070

7171
@tag :authenticated
@@ -107,7 +107,7 @@ defmodule CodeCorpsWeb.ProjectSkillControllerTest do
107107
user_id = current_user.id
108108
traits = project_skill |> SegmentTraitsBuilder.build
109109

110-
assert_received({:track, ^user_id, "Removed ProjectSkill", ^traits})
110+
assert_received({:track, ^user_id, "Removed Project Skill", ^traits})
111111
end
112112

113113
test "renders 401 when unauthenticated", %{conn: conn} do

0 commit comments

Comments
 (0)