Added tracking for GithubAppInstallation created

Author: begedin

lib/code_corps/analytics/segment_traits_builder.ex

@@ -25,6 +25,18 @@ defmodule CodeCorps.Analytics.SegmentTraitsBuilder do
       project_id: donation_goal.project_id
     }
   end
+  defp traits(%CodeCorps.GithubAppInstallation{} = installation) do
+    %{
+      access_token_expires_at: installation.access_token_expires_at,
+      github_account_login: installation.github_account_login,
+      github_account_type: installation.github_account_type,
+      github_id: installation.github_id,
+      origin: installation.origin,
+      state: installation.state,
+      project_id: installation.project_id,
+      user_id: installation.user_id
+    }
+  end
   defp traits(%CodeCorps.ProjectSkill{} = record) do
     record = record |> Repo.preload([:project, :skill])
     %{

lib/code_corps_web/controllers/github_app_installation_controller.ex

@@ -4,7 +4,7 @@ defmodule CodeCorpsWeb.GithubAppInstallationController do
 
   import CodeCorps.Helpers.Query, only: [id_filter: 2]
 
-  alias CodeCorps.{GithubAppInstallation, User}
+  alias CodeCorps.{Analytics.SegmentTracker, GithubAppInstallation, User}
 
   action_fallback CodeCorpsWeb.FallbackController
   plug CodeCorpsWeb.Plug.DataToAttributes
@@ -29,7 +29,14 @@ defmodule CodeCorpsWeb.GithubAppInstallationController do
     with %User{} = current_user <- conn |> Guardian.Plug.current_resource,
          {:ok, :authorized} <- current_user |> Policy.authorize(:create, %GithubAppInstallation{}, params),
          {:ok, %GithubAppInstallation{} = installation} <- %GithubAppInstallation{} |> GithubAppInstallation.create_changeset(params) |> Repo.insert do
+
+      current_user |> track_created(installation)
       conn |> put_status(:created) |> render("show.json-api", data: installation)
     end
   end
+
+  @spec track_created(User.t, GithubAppInstallation.t) :: any
+  defp track_created(%User{id: user_id}, %GithubAppInstallation{} = installation) do
+    user_id |> SegmentTracker.track("Created GithubAppInstallation", installation)
+  end
 end

test/lib/code_corps/analytics/segment_traits_builder_test.exs

@@ -16,6 +16,8 @@ defmodule CodeCorps.Analytics.SegmentTraitsBuilderTest do
       assert :comment |> insert |> SegmentTraitsBuilder.build
       assert :donation_goal |> insert |> SegmentTraitsBuilder.build
 
+      assert :github_app_installation |> insert |> SegmentTraitsBuilder.build
+
       assert :project_skill |> insert |> SegmentTraitsBuilder.build
       assert :project_user |> insert |> SegmentTraitsBuilder.build
 

test/lib/code_corps_web/controllers/github_app_installation_controller_test.exs

@@ -3,6 +3,8 @@ defmodule CodeCorpsWeb.GithubAppInstallationControllerTest do
 
   use CodeCorpsWeb.ApiCase, resource_name: :github_app_installation
 
+  alias CodeCorps.{Analytics.SegmentTraitsBuilder, GithubAppInstallation, Repo}
+
   describe "index" do
     test "lists all resources", %{conn: conn} do
       [record_1, record_2] = insert_pair(:github_app_installation)
@@ -49,6 +51,19 @@ defmodule CodeCorpsWeb.GithubAppInstallationControllerTest do
       assert conn |> request_create(attrs) |> json_response(201)
     end
 
+    @tag :authenticated
+    test "tracks creation", %{conn: conn, current_user: current_user} do
+      project = insert(:project)
+      insert(:project_user, project: project, user: current_user, role: "owner")
+      attrs = %{project: project, user: current_user}
+
+      conn |> request_create(attrs)
+
+      user_id = current_user.id
+      traits = GithubAppInstallation |> Repo.one |> SegmentTraitsBuilder.build
+      assert_receive({:track, ^user_id, "Created GithubAppInstallation", ^traits})
+    end
+
     @tag :authenticated
     test "does not create resource and renders 422 when data is invalid", %{conn: conn, current_user: user} do
       project = insert(:project)