Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GitHub webhook processing logic into handlers #1258

Open
joshsmith opened this issue Nov 27, 2017 · 0 comments
Open

Refactor GitHub webhook processing logic into handlers #1258

joshsmith opened this issue Nov 27, 2017 · 0 comments
Labels
needs clarification Priority: Low
Milestone
💅 GitHub integrat...

Comments

@joshsmith
Copy link
Contributor

Problem

There are "classes" of webhooks, some of which pertain to the repository and project and other that don't (installation, e.g.). As CC adds more webhook handlers for various reasons, the should_process? function will become increasingly further away from the handler logic, so this should eventually move down into the event handler logic, with the controller merely being a dispatcher.

#1254 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs clarification Priority: Low
Projects
None yet
Milestone
💅 GitHub integration polish
Development

No branches or pull requests
1 participant
@joshsmith