Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHANGE] - Retrun statement of common code of the extraction bricks needs to be reworked #382

Open
LeonardPuettmannKern opened this issue Oct 17, 2023 · 0 comments
Open

[CHANGE] - Retrun statement of common code of the extraction bricks needs to be reworked #382

LeonardPuettmannKern opened this issue Oct 17, 2023 · 0 comments
Assignees
@LeonardPuettmannKern
Labels
enhancement New feature or request

Comments

@LeonardPuettmannKern
Copy link
Contributor

LeonardPuettmannKern commented Oct 17, 2023 •
edited
Loading

Currently, we return an extraction_keyword with all extraction bricks, which is passed to the function of the brick and then returned again, which is not efficient. Instead it might make more sense to return <value>, <start_char_idx>, <end_char_idx>. This need to be then applied for all bricks.
@LeonardPuettmannKern LeonardPuettmannKern added the enhancement New feature or request label Oct 17, 2023
@LeonardPuettmannKern LeonardPuettmannKern self-assigned this Oct 17, 2023
Merged
13 tasks
@LeonardPuettmannKern LeonardPuettmannKern changed the title [CHANGE] - Retrun of the extraction bricks needs to be reworked [CHANGE] - Retrun statement of common code of the extraction bricks needs to be reworked Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeonardPuettmannKern LeonardPuettmannKern

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LeonardPuettmannKern