Add title attribute to all buttons #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/containers/popup.tsx
Outdated
| @@ -164,7 +164,12 @@ export class Popup extends React.Component<POPUP_PROPS & DispatchProps, {}> { | |||
| </svg> | |||
| <span>INTERCEPTOR</span> | |||
| </a> | |||
| <button type="button" onClick={this.handleClick} className={buttonClass}> | |||
| <button | |||
| title="Start/Stop Listening to Requests" | |||
There was a problem hiding this comment.
can be conditionally set either start or stop.
app/containers/popup.tsx
Outdated
| <button type="button" onClick={this.handleClick} className={buttonClass}> | ||
| {this.props.enabled ? "Stop Listening" : "Start Listening"} | ||
| <button | ||
| title={enabled ? "Stop Listening to Requests" : "Start Listening to Requests"} |
There was a problem hiding this comment.
use props.enabled to make it consistent across the component. No need for enabled as separate const.
revathskumar
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#123