feat(plugin-lighthouse): keep audit values as floats

code-pushup · Jun 27, 2024 · 2627a87 · 2627a87
1 parent e9b8fd1
commit 2627a87
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/plugin-lighthouse/src/lib/runner/utils.ts b/packages/plugin-lighthouse/src/lib/runner/utils.ts
@@ -50,7 +50,7 @@ export function toAuditOutputs(
       const auditOutput: AuditOutput = {
         slug,
         score: score ?? 1, // score can be null
-        value: Number.parseInt(value.toString(), 10),
+        value,
         displayValue,
       };
 

diff --git a/packages/plugin-lighthouse/src/lib/runner/utils.unit.test.ts b/packages/plugin-lighthouse/src/lib/runner/utils.unit.test.ts
@@ -91,7 +91,7 @@ describe('toAuditOutputs', () => {
     ).not.toThrow();
   });
 
-  it('should parse valid lhr float value to integer', () => {
+  it('should copy lhr numericValue to audit value as float', () => {
     expect(
       toAuditOutputs([
         {
@@ -106,7 +106,7 @@ describe('toAuditOutputs', () => {
           displayValue: '2.8 s',
         },
       ]),
-    ).toStrictEqual([expect.objectContaining({ value: 2838 })]);
+    ).toStrictEqual([expect.objectContaining({ value: 2838.974 })]);
   });
 
   it('should convert null score to 1', () => {