-
Notifications
You must be signed in to change notification settings - Fork 15
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(utils): implement diff markdown comment for monorepos
- Loading branch information
1 parent
7d77b51
commit 3cf7b11
Showing
8 changed files
with
292 additions
and
35 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
packages/utils/src/lib/reports/__snapshots__/report-diff-monorepo-with-portal.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| # Code PushUp | ||
|
|
||
| 🥳 Code PushUp report has **improved** – compared target commit 0123456789abcdef0123456789abcdef01234567 with source commit abcdef0123456789abcdef0123456789abcdef01. | ||
|
|
||
| ## 💼 Project `frontoffice` – improved 🥳 | ||
|
|
||
| [🕵️ See full comparison in Code PushUp portal 🔍](https://app.code-pushup.dev/portal/dunder-mifflin/frontoffice/comparison/abcdef0123456789abcdef0123456789abcdef01/0123456789abcdef0123456789abcdef01234567) | ||
|
|
||
| | 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change | | ||
| | :------------------------------------------------------------------------ | :--------------: | :-------------: | :------------------------------------------------------------: | | ||
| | Code style | 🟡 54 | 🟢 **100** |  | | ||
| | Bug prevention | 🟡 68 | 🟢 **95** |  | | ||
| | [Performance](https://developers.google.com/web/fundamentals/performance) | 🟢 92 | 🟢 **94** |  | | ||
|
|
||
| <details> | ||
| <summary>👍 <strong>2</strong> groups improved, 👍 <strong>12</strong> audits improved</summary> | ||
|
|
||
| ### 🗃️ Groups | ||
|
|
||
| | 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change | | ||
| | :----------------------------------------------------------------- | :----------------------- | :--------------: | :-------------: | :------------------------------------------------------------: | | ||
| | [ESLint](https://www.npmjs.com/package/@code-pushup/eslint-plugin) | Maximum lines limitation | 🟡 50 | 🟢 **100** |  | | ||
| | Lighthouse | Performance | 🟢 92 | 🟢 **94** |  | | ||
|
|
||
| ### 🛡️ Audits | ||
|
|
||
| | 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change | | ||
| | :----------------------------------------------------------------- | :--------------------------------------------------------------------------------------------------------------------------------------------------- | :---------------: | :--------------: | :----------------------------------------------------------------------------------: | | ||
| | [ESLint](https://www.npmjs.com/package/@code-pushup/eslint-plugin) | [Disallow variable declarations from shadowing variables declared in the outer scope](https://eslint.org/docs/latest/rules/no-shadow) | 🟥 3 warnings | 🟩 **passed** |  | | ||
| | [ESLint](https://www.npmjs.com/package/@code-pushup/eslint-plugin) | [Require or disallow method and property shorthand syntax for object literals](https://eslint.org/docs/latest/rules/object-shorthand) | 🟥 3 warnings | 🟩 **passed** |  | | ||
| | [ESLint](https://www.npmjs.com/package/@code-pushup/eslint-plugin) | [verifies the list of dependencies for Hooks like useEffect and similar](https://github.com/facebook/react/issues/14920) | 🟥 2 warnings | 🟩 **passed** |  | | ||
| | [ESLint](https://www.npmjs.com/package/@code-pushup/eslint-plugin) | [Disallow unused variables](https://eslint.org/docs/latest/rules/no-unused-vars) | 🟥 1 warning | 🟩 **passed** |  | | ||
| | [ESLint](https://www.npmjs.com/package/@code-pushup/eslint-plugin) | [Require braces around arrow function bodies](https://eslint.org/docs/latest/rules/arrow-body-style) | 🟥 1 warning | 🟩 **passed** |  | | ||
| | [ESLint](https://www.npmjs.com/package/@code-pushup/eslint-plugin) | [Require the use of `===` and `!==`](https://eslint.org/docs/latest/rules/eqeqeq) | 🟥 1 warning | 🟩 **passed** |  | | ||
| | [ESLint](https://www.npmjs.com/package/@code-pushup/eslint-plugin) | [Enforce a maximum number of lines of code in a function](https://eslint.org/docs/latest/rules/max-lines-per-function) | 🟥 1 warning | 🟩 **passed** |  | | ||
| | [ESLint](https://www.npmjs.com/package/@code-pushup/eslint-plugin) | [Require `const` declarations for variables that are never reassigned after declared](https://eslint.org/docs/latest/rules/prefer-const) | 🟥 1 warning | 🟩 **passed** |  | | ||
| | [ESLint](https://www.npmjs.com/package/@code-pushup/eslint-plugin) | [Disallow missing `key` props in iterators/collection literals](https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-key.md) | 🟥 1 warning | 🟩 **passed** |  | | ||
| | Lighthouse | [Largest Contentful Paint](https://developer.chrome.com/docs/lighthouse/performance/largest-contentful-paint/) | 🟨 1.5 s | 🟨 **1.4 s** |  | | ||
| | Lighthouse | [First Contentful Paint](https://developer.chrome.com/docs/lighthouse/performance/first-contentful-paint/) | 🟨 1.2 s | 🟨 **1.1 s** |  | | ||
| | Lighthouse | [Speed Index](https://developer.chrome.com/docs/lighthouse/performance/speed-index/) | 🟩 1.2 s | 🟩 **1.1 s** |  | | ||
|
|
||
| 41 other audits are unchanged. | ||
|
|
||
| </details> | ||
|
|
||
| ## 💼 Project `backoffice` – unchanged 😐 | ||
|
|
||
| [🕵️ See full comparison in Code PushUp portal 🔍](https://app.code-pushup.dev/portal/dunder-mifflin/backoffice/comparison/abcdef0123456789abcdef0123456789abcdef01/0123456789abcdef0123456789abcdef01234567) | ||
|
|
||
| | 🏷️ Category | ⭐ Score | | ||
| | :------------- | :-----: | | ||
| | Performance | 🟢 92 | | ||
| | Bug prevention | 🟡 68 | | ||
| | Code style | 🟡 54 | |
Oops, something went wrong.