Skip to content

Commit 6d2b667

Browse files
committed
Revert "add remaining videos"
This reverts commit 4e436bb.
1 parent ac58b05 commit 6d2b667

File tree

3 files changed

+8
-20
lines changed

3 files changed

+8
-20
lines changed

packages/dev/s2-docs/pages/react-aria/blog/building-a-combobox.mdx

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@ governing permissions and limitations under the License. */}
1010
import comboboxExampleImageUrl from 'url:../../../../docs/pages/assets/combobox-example.png';
1111
import screenreaderSpreadsheetImageUrl from 'url:../../../../docs/pages/assets/screenreader-spreadsheet-combobox.png';
1212
import comboboxAccessibilityUrl from 'url:../../../../docs/pages/assets/combobox-accessibility.mp4';
13-
import comboboxVideoUrl from 'url:../../../../docs/pages/assets/combobox.mp4';
14-
import comboboxVisualViewportUrl from 'url:../../../../docs/pages/assets/combobox-visual-viewport.mp4';
15-
import comboboxScrollingUrl from 'url:../../../../docs/pages/assets/combobox-scrolling-safari.mp4';
1613

1714
import {BlogPostLayout} from '../../../src/Layout';
1815
export default BlogPostLayout;
@@ -36,7 +33,7 @@ After many months of research, development, and extensive testing across browser
3633
- **Asynchronous loading** — Autocomplete suggestions can be loaded asynchronously, and large lists can be loaded on demand through infinite scrolling.
3734
- **Customizability** — React Aria hooks allow full control over the rendering and styling of your ComboBox component, while letting us take care of the behavioral complexities for you. Use our default filter or you can provide custom filtering for complete control.
3835

39-
<video src={comboboxVideoUrl} loop autoPlay muted style={{maxWidth: 'min(100%, 1920px)', display: 'block', margin: '40px auto'}} />
36+
TODO: Add comboboxVideoUrl video
4037

4138
## Building a ComboBox
4239

@@ -68,7 +65,7 @@ Luckily for us, iOS 13 added support for the [VisualViewport](https://developer.
6865
when the onscreen keyboard was opened or dismissed by listening to the VisualViewport's `resize` event. Leveraging these two allowed us to create a tray that properly adjusts to the presence of iOS onscreen keyboard. Check out the video below
6966
to see how the ComboBox tray worked before and after we switched to the VisualViewport API. If you'd like to track the visual viewport size in your own app, you can use the [useViewportSize](https://github.com/adobe/react-spectrum/blob/main/packages/@react-aria/utils/src/useViewportSize.ts) hook available in the `@react-aria/utils` package.
7067

71-
<video src={comboboxVisualViewportUrl} loop autoPlay muted style={{maxWidth: 'min(80%, 350px)', display: 'block', margin: '20px auto'}} />
68+
TODO: Add comboboxVisualViewportUrl video
7269

7370
### Page Scrolling
7471

@@ -77,7 +74,7 @@ now that our ComboBox tray sizes itself to fit in the visual viewport, users cou
7774
or root element of the document. This preserves the user's ability to scroll through the options in the tray but blocks any attempt to scroll the page itself until the tray is closed. The video below
7875
illustrates the difference in scrolling behavior before and after our fix. If you are building your own overlays and would like to prevent this kind of document scrolling behavior, check out the [usePreventScroll](https://github.com/adobe/react-spectrum/blob/main/packages/@react-aria/overlays/src/usePreventScroll.ts) hook in the `react-aria/overlays` package.
7976

80-
<video src={comboboxScrollingUrl} loop autoPlay muted style={{maxWidth: 'min(80%, 350px)', display: 'block', margin: '20px auto'}} />
77+
TODO: Add comboboxScrollingUrl video
8178

8279
## Accessibility
8380

packages/dev/s2-docs/pages/react-aria/blog/date-and-time-pickers-for-all.mdx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@ governing permissions and limitations under the License. */}
1010
import Anatomy from '../../../../docs/pages/assets/daterangepicker-anatomy.svg';
1111
import calendarMobileScreenReader from 'url:../../../../docs/pages/assets/calendar-mobile-screen-reader.mp4';
1212
import calendarMobileScreenReaderVTT from 'url:../../../../docs/pages/assets/calendar-mobile-screen-reader.vtt';
13-
import datepickerVideo from 'url:../../../../docs/pages/assets/datepicker.mp4';
14-
import datepickerScreenReader from 'url:../../../../docs/pages/assets/datepicker-screen-reader.mp4';
15-
1613
import {BlogPostLayout} from '../../../src/Layout';
1714
export default BlogPostLayout;
1815

@@ -41,7 +38,7 @@ In building these components, we have focused on the following areas:
4138
- **Accessibility** – All of our date and time picker components have been tested across desktop and mobile devices, and with many different input methods including mouse, touch, and keyboard. We have worked hard to ensure screen reader announcements are clear and consistent.
4239
- **Customizability** – As with all of React Aria, our hooks give you full control over the rendering and styling of your components, while letting us handle the internationalization and accessibility challenges for you. We have examples using many different styling libraries, such as Tailwind CSS, Styled Components, CSS modules, and Chakra UI.
4340

44-
<video src={datepickerVideo} loop autoPlay muted style={{maxWidth: 'min(100%, 1920px)', display: 'block', margin: '40px auto'}} />
41+
TODO: Add datepickerVideoUrl video
4542

4643
## User experience
4744

@@ -63,7 +60,7 @@ We took a different approach, and followed the lead of native date picker UIs on
6360

6461
This approach has benefits for internationalization and accessibility, as well as usability on mobile. For internationalization, individual segments avoid the problem of parsing dates in various formats entirely. The date format is automatically determined based on the locale, and the user only needs to fill in the values and not worry about messing up the separators or getting the order wrong. Each segment is also individually labeled for accessibility, so users always know which field they are on (e.g. "year", "month", "day", etc.). This is much easier to use for screen reader users than a plain text field where the expected format is unknown. Finally, on mobile, we can take advantage of the numeric software keyboard, which is nicer to use than a full QWERTY keyboard.
6562

66-
<video src={datepickerScreenReader} loop autoPlay muted style={{maxWidth: 'min(100%, 1920px)', display: 'block', margin: '40px auto'}} />
63+
TODO: Add datefieldVideoUrl video
6764

6865
The [useDateField](../useDateField.html) and [useTimeField](../useTimeField.html) hooks (or the [DateField](../../s2/DateField.html) and [TimeField](../../s2/TimeField.html) React Spectrum components) may be used standalone in cases where the user is likely to already know the date they need to enter, or the date is far in the past or future, e.g. a birthday or passport expiration date. In these cases, browsing through a calendar UI to find a date is tedious, and entering the date with a keyboard is much more efficient.
6966

packages/dev/s2-docs/pages/react-aria/blog/drag-and-drop.mdx

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,6 @@ import Anatomy from '@react-aria/dnd/docs/Anatomy.svg';
1111
import BetweenDropPosition from '@react-aria/dnd/docs/BetweenDropPosition.svg';
1212
import OnDropPosition from '@react-aria/dnd/docs/OnDropPosition.svg';
1313
import RootDropPosition from '@react-aria/dnd/docs/RootDropPosition.svg';
14-
import heroVideo from 'url:../../../../docs/pages/assets/dnd.mp4';
15-
import dndKeyboard from 'url:../../../../docs/pages/assets/dnd-keyboard.mp4';
16-
import dndMobile from 'url:../../../../docs/pages/assets/dnd-mobile.mp4';
17-
import dndMobileVTT from 'url:../../../../docs/pages/assets/dnd-mobile.vtt';
1814
import DragBetweenListsExample from './DragBetweenListsExample';
1915

2016
import {BlogPostLayout} from '../../../src/Layout';
@@ -39,7 +35,7 @@ We are excited to announce the release of drag and drop support in [React Aria](
3935
- **Interoperability** – Drag data can be provided in multiple data formats for compatibility with many targets and external applications via the native HTML drag and drop API. Drag and drop integrates with multiple selection to allow dragging many objects at once.
4036
- **Customizability** – Interactions such as hit testing, keyboard navigation, and drop operations can be customized, as well as UIs for drag previews and drop indicators.
4137

42-
<video src={heroVideo} loop autoPlay muted style={{maxWidth: 'min(100%, 1920px)', display: 'block', margin: '40px auto'}} />
38+
TODO: Add heroVideo video
4339

4440
## Introduction
4541

@@ -61,15 +57,13 @@ For mouse and touch screen users, React Aria uses the native [HTML drag and drop
6157

6258
In addition to native drag and drop, we have also implemented keyboard and screen reader accessible interactions from scratch. Keyboard users can focus a draggable element and press the `Enter` key to start dragging it. This enters a drag and drop mode across the whole page, which allows the user to press `Tab` to navigate only between drop targets that accept the dragged data, while skipping over all other elements. This reduces the number of elements on the page that must be traversed to find a drop target, and removes the guess work often found with other alternatives such as copy and paste. Once a target is chosen, pressing the `Enter` key again performs the drop.
6359

64-
<video src={dndKeyboard} loop autoPlay muted style={{maxWidth: 'min(100%, 1920px)', display: 'block', margin: '40px auto'}} />
60+
TODO: Add video showing drag and drop using a keyboard
6561

6662
For screen reader users, the interactions are similar. We've taken great care to include prompts and announcements to help guide the user through the process, which adapt to the device, and are localized into over 30 languages. Drag sources and drop targets include ARIA descriptions indicating that the user can press `Enter` or double tap to drag or drop, depending on their device. We also use an ARIA live region to announce when a drag starts, with instructions on how to navigate and perform a drop, and to announce when a drop is completed successfully or canceled by the user.
6763

6864
In addition, while in drag and drop mode, all elements other than valid drop targets are hidden from screen readers. Desktop screen reader users can use the `Tab` key to navigate as described earlier, but touch screen readers navigate by swiping through elements using a virtual cursor, and double tapping to drop. Hiding all non-drop target elements makes it much easier to find valid places to drop, without needing to swipe through potentially hundreds of unrelated elements.
6965

70-
<video src={dndMobile} loop autoPlay muted style={{maxWidth: 'min(100%, 1920px)', display: 'block', margin: '40px auto'}}>
71-
<Track src={dndMobileVTT} default kind="captions" label="English Captions" srclang="en-us" type="text/vtt" />
72-
</video>
66+
TODO: Add video showing drag and drop using VoiceOver on iOS
7367

7468
All of these accessibility features are implemented behind the scenes using the same API as for mouse and touch interactions. There is no additional effort required by the developer to make drag and drop accessible.
7569

0 commit comments

Comments
 (0)