Skip to content

Commit 1c34fd1

Browse files
committed
Use the JSX of the ViewTransition as the Stack Trace of "Animating" Traces (facebook#34539)
Stacked on facebook#34538. Track the Task of the first ViewTransition that we detected as animating. Use this as the Task as "Starting Animation", "Animating" etc. That way you can see which ViewTransition spawned the Animation. Although it's likely to be multiple. <img width="757" height="393" alt="Screenshot 2025-09-19 at 10 19 18 PM" src="https://github.com/user-attachments/assets/a6cdcb89-bd02-40ec-b3c3-11121c29e892" /> DiffTrain build for [d91d28c](facebook@d91d28c)
1 parent 490f8ff commit 1c34fd1

24 files changed

+1347
-1311
lines changed

compiled-rn/VERSION_NATIVE_FB

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.2.0-native-fb-115e3ec1-20250920
1+
19.2.0-native-fb-d91d28c8-20250920

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<78ca3f62bf1963967566e487d36b0b6b>>
10+
* @generated SignedSource<<d87881a485f74e628a191b6631cf144b>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.2.0-native-fb-115e3ec1-20250920";
407+
exports.version = "19.2.0-native-fb-d91d28c8-20250920";
408408
})();

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<8a0dcfb1a9c3549ca1d7b2ab852dd404>>
10+
* @generated SignedSource<<b49a66735f0b6e7f8804c650f1e0430a>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-115e3ec1-20250920";
206+
exports.version = "19.2.0-native-fb-d91d28c8-20250920";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<8a0dcfb1a9c3549ca1d7b2ab852dd404>>
10+
* @generated SignedSource<<b49a66735f0b6e7f8804c650f1e0430a>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-115e3ec1-20250920";
206+
exports.version = "19.2.0-native-fb-d91d28c8-20250920";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js

Lines changed: 247 additions & 229 deletions
Large diffs are not rendered by default.

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js

Lines changed: 35 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<17a72420e02b48d7bec04f6db9cb56d6>>
10+
* @generated SignedSource<<574b918999c97c8597a7be2afa60cf40>>
1111
*/
1212

1313
/*
@@ -11658,6 +11658,7 @@ function performWorkOnRoot(root$jscomp$0, lanes, forceSync) {
1165811658
!workInProgressRootDidSkipSuspendedSiblings
1165911659
);
1166011660
if (0 !== getNextLanes(shouldTimeSlice, 0, !0)) break a;
11661+
pendingEffectsLanes = lanes;
1166111662
shouldTimeSlice.timeoutHandle = scheduleTimeout(
1166211663
commitRootWhenReady.bind(
1166311664
null,
@@ -11672,7 +11673,7 @@ function performWorkOnRoot(root$jscomp$0, lanes, forceSync) {
1167211673
workInProgressSuspendedRetryLanes,
1167311674
workInProgressRootDidSkipSuspendedSiblings,
1167411675
renderWasConcurrent,
11675-
2,
11676+
"Throttled",
1167611677
-0,
1167711678
0
1167811679
),
@@ -11692,7 +11693,7 @@ function performWorkOnRoot(root$jscomp$0, lanes, forceSync) {
1169211693
workInProgressSuspendedRetryLanes,
1169311694
workInProgressRootDidSkipSuspendedSiblings,
1169411695
renderWasConcurrent,
11695-
0,
11696+
null,
1169611697
-0,
1169711698
0
1169811699
);
@@ -11731,6 +11732,7 @@ function commitRootWhenReady(
1173111732
imgBytes: 0,
1173211733
suspenseyImages: [],
1173311734
waitingForImages: !0,
11735+
waitingForViewTransition: !1,
1173411736
unsuspend: noop$1
1173511737
};
1173611738
accumulateSuspenseyCommitOnFiber(
@@ -11749,6 +11751,7 @@ function commitRootWhenReady(
1174911751
timeoutOffset
1175011752
);
1175111753
if (null !== timeoutOffset) {
11754+
pendingEffectsLanes = lanes;
1175211755
root.cancelPendingCommit = timeoutOffset(
1175311756
commitRoot.bind(
1175411757
null,
@@ -11763,7 +11766,7 @@ function commitRootWhenReady(
1176311766
suspendedRetryLanes,
1176411767
exitStatus,
1176511768
suspendedCommitReason,
11766-
1,
11769+
null,
1176711770
completedRenderStartTime,
1176811771
completedRenderEndTime
1176911772
)
@@ -11868,6 +11871,7 @@ function prepareFreshStack(root, lanes) {
1186811871
timeoutHandle = root.cancelPendingCommit;
1186911872
null !== timeoutHandle &&
1187011873
((root.cancelPendingCommit = null), timeoutHandle());
11874+
pendingEffectsLanes = 0;
1187111875
resetWorkInProgressStack();
1187211876
workInProgressRoot = root;
1187311877
workInProgress = timeoutHandle = createWorkInProgress(root.current, null);
@@ -13187,20 +13191,20 @@ function debounceScrollEnd(targetInst, nativeEvent, nativeEventTarget) {
1318713191
(nativeEventTarget[internalScrollTimer] = targetInst));
1318813192
}
1318913193
for (
13190-
var i$jscomp$inline_1663 = 0;
13191-
i$jscomp$inline_1663 < simpleEventPluginEvents.length;
13192-
i$jscomp$inline_1663++
13194+
var i$jscomp$inline_1643 = 0;
13195+
i$jscomp$inline_1643 < simpleEventPluginEvents.length;
13196+
i$jscomp$inline_1643++
1319313197
) {
13194-
var eventName$jscomp$inline_1664 =
13195-
simpleEventPluginEvents[i$jscomp$inline_1663],
13196-
domEventName$jscomp$inline_1665 =
13197-
eventName$jscomp$inline_1664.toLowerCase(),
13198-
capitalizedEvent$jscomp$inline_1666 =
13199-
eventName$jscomp$inline_1664[0].toUpperCase() +
13200-
eventName$jscomp$inline_1664.slice(1);
13198+
var eventName$jscomp$inline_1644 =
13199+
simpleEventPluginEvents[i$jscomp$inline_1643],
13200+
domEventName$jscomp$inline_1645 =
13201+
eventName$jscomp$inline_1644.toLowerCase(),
13202+
capitalizedEvent$jscomp$inline_1646 =
13203+
eventName$jscomp$inline_1644[0].toUpperCase() +
13204+
eventName$jscomp$inline_1644.slice(1);
1320113205
registerSimpleEvent(
13202-
domEventName$jscomp$inline_1665,
13203-
"on" + capitalizedEvent$jscomp$inline_1666
13206+
domEventName$jscomp$inline_1645,
13207+
"on" + capitalizedEvent$jscomp$inline_1646
1320413208
);
1320513209
}
1320613210
registerSimpleEvent(ANIMATION_END, "onAnimationEnd");
@@ -17523,16 +17527,16 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1752317527
0 === i && attemptExplicitHydrationTarget(target);
1752417528
}
1752517529
};
17526-
var isomorphicReactPackageVersion$jscomp$inline_2072 = React.version;
17530+
var isomorphicReactPackageVersion$jscomp$inline_2052 = React.version;
1752717531
if (
17528-
"19.2.0-native-fb-115e3ec1-20250920" !==
17529-
isomorphicReactPackageVersion$jscomp$inline_2072
17532+
"19.2.0-native-fb-d91d28c8-20250920" !==
17533+
isomorphicReactPackageVersion$jscomp$inline_2052
1753017534
)
1753117535
throw Error(
1753217536
formatProdErrorMessage(
1753317537
527,
17534-
isomorphicReactPackageVersion$jscomp$inline_2072,
17535-
"19.2.0-native-fb-115e3ec1-20250920"
17538+
isomorphicReactPackageVersion$jscomp$inline_2052,
17539+
"19.2.0-native-fb-d91d28c8-20250920"
1753617540
)
1753717541
);
1753817542
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17552,24 +17556,24 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1755217556
null === componentOrElement ? null : componentOrElement.stateNode;
1755317557
return componentOrElement;
1755417558
};
17555-
var internals$jscomp$inline_2645 = {
17559+
var internals$jscomp$inline_2625 = {
1755617560
bundleType: 0,
17557-
version: "19.2.0-native-fb-115e3ec1-20250920",
17561+
version: "19.2.0-native-fb-d91d28c8-20250920",
1755817562
rendererPackageName: "react-dom",
1755917563
currentDispatcherRef: ReactSharedInternals,
17560-
reconcilerVersion: "19.2.0-native-fb-115e3ec1-20250920"
17564+
reconcilerVersion: "19.2.0-native-fb-d91d28c8-20250920"
1756117565
};
1756217566
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
17563-
var hook$jscomp$inline_2646 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
17567+
var hook$jscomp$inline_2626 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
1756417568
if (
17565-
!hook$jscomp$inline_2646.isDisabled &&
17566-
hook$jscomp$inline_2646.supportsFiber
17569+
!hook$jscomp$inline_2626.isDisabled &&
17570+
hook$jscomp$inline_2626.supportsFiber
1756717571
)
1756817572
try {
17569-
(rendererID = hook$jscomp$inline_2646.inject(
17570-
internals$jscomp$inline_2645
17573+
(rendererID = hook$jscomp$inline_2626.inject(
17574+
internals$jscomp$inline_2625
1757117575
)),
17572-
(injectedHook = hook$jscomp$inline_2646);
17576+
(injectedHook = hook$jscomp$inline_2626);
1757317577
} catch (err) {}
1757417578
}
1757517579
exports.createRoot = function (container, options) {
@@ -17664,4 +17668,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1766417668
listenToAllSupportedEvents(container);
1766517669
return new ReactDOMHydrationRoot(initialChildren);
1766617670
};
17667-
exports.version = "19.2.0-native-fb-115e3ec1-20250920";
17671+
exports.version = "19.2.0-native-fb-d91d28c8-20250920";

0 commit comments

Comments
 (0)