Skip to content

Commit 7b3697d

Browse files
pull[bot]pull[bot]
committed
[Flight] Don't drop debug info if there's only a readable debug channel (facebook#34304)
When the Flight Client is waiting for pending debug chunks, it drops the debug info if there is no writable side of the debug channel defined. However, it should instead check if there's no readable side defined. Fixing this is not only important for browser clients that don't want or need a return channel, but it's also crucial for server-side rendering, because the Node and Edge clients only accept a readable side of the debug channel. So they can't even define a noop writable side as a workaround. DiffTrain build for [9c2e2b8](facebook@9c2e2b8)
1 parent d5fe75a commit 7b3697d

24 files changed

+130
-94
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.2.0-native-fb-090777d7-20250822
1+
19.2.0-native-fb-9c2e2b84-20250827

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<3bddf84b600f85924aafe51b3c7b6749>>
10+
* @generated SignedSource<<8f4d42ab7863da982c84ecec5ec9eeec>>
1111
*/
1212

1313
"use strict";
@@ -404,5 +404,5 @@ __DEV__ &&
404404
exports.useFormStatus = function () {
405405
return resolveDispatcher().useHostTransitionStatus();
406406
};
407-
exports.version = "19.2.0-native-fb-090777d7-20250822";
407+
exports.version = "19.2.0-native-fb-9c2e2b84-20250827";
408408
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<4d5438324f88b8ab3c1433025bf034ba>>
10+
* @generated SignedSource<<85bbe0cc61c8be36bfaab2deeba55b4e>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-090777d7-20250822";
206+
exports.version = "19.2.0-native-fb-9c2e2b84-20250827";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<4d5438324f88b8ab3c1433025bf034ba>>
10+
* @generated SignedSource<<85bbe0cc61c8be36bfaab2deeba55b4e>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.2.0-native-fb-090777d7-20250822";
206+
exports.version = "19.2.0-native-fb-9c2e2b84-20250827";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js‎

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<c7a0b803fbb2f39070dbec25c9564f66>>
10+
* @generated SignedSource<<cdc973d618424519b9abfde41b401e08>>
1111
*/
1212

1313
/*
@@ -23584,7 +23584,13 @@ __DEV__ &&
2358423584
}
2358523585
function canHydrateHydrationBoundary(instance, inRootOrSingleton) {
2358623586
for (; 8 !== instance.nodeType; ) {
23587-
if (!inRootOrSingleton) return null;
23587+
if (
23588+
(1 !== instance.nodeType ||
23589+
"INPUT" !== instance.nodeName ||
23590+
"hidden" !== instance.type) &&
23591+
!inRootOrSingleton
23592+
)
23593+
return null;
2358823594
instance = getNextHydratable(instance.nextSibling);
2358923595
if (null === instance) return null;
2359023596
}
@@ -29367,11 +29373,11 @@ __DEV__ &&
2936729373
};
2936829374
(function () {
2936929375
var isomorphicReactPackageVersion = React.version;
29370-
if ("19.2.0-native-fb-090777d7-20250822" !== isomorphicReactPackageVersion)
29376+
if ("19.2.0-native-fb-9c2e2b84-20250827" !== isomorphicReactPackageVersion)
2937129377
throw Error(
2937229378
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2937329379
(isomorphicReactPackageVersion +
29374-
"\n - react-dom: 19.2.0-native-fb-090777d7-20250822\nLearn more: https://react.dev/warnings/version-mismatch")
29380+
"\n - react-dom: 19.2.0-native-fb-9c2e2b84-20250827\nLearn more: https://react.dev/warnings/version-mismatch")
2937529381
);
2937629382
})();
2937729383
("function" === typeof Map &&
@@ -29408,10 +29414,10 @@ __DEV__ &&
2940829414
!(function () {
2940929415
var internals = {
2941029416
bundleType: 1,
29411-
version: "19.2.0-native-fb-090777d7-20250822",
29417+
version: "19.2.0-native-fb-9c2e2b84-20250827",
2941229418
rendererPackageName: "react-dom",
2941329419
currentDispatcherRef: ReactSharedInternals,
29414-
reconcilerVersion: "19.2.0-native-fb-090777d7-20250822"
29420+
reconcilerVersion: "19.2.0-native-fb-9c2e2b84-20250827"
2941529421
};
2941629422
internals.overrideHookState = overrideHookState;
2941729423
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -29550,5 +29556,5 @@ __DEV__ &&
2955029556
listenToAllSupportedEvents(container);
2955129557
return new ReactDOMHydrationRoot(initialChildren);
2955229558
};
29553-
exports.version = "19.2.0-native-fb-090777d7-20250822";
29559+
exports.version = "19.2.0-native-fb-9c2e2b84-20250827";
2955429560
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js‎

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<72fafe42074f3f5af1f68fe2631a7f33>>
10+
* @generated SignedSource<<6e58f48b8312337cbe7019ccb8db9a32>>
1111
*/
1212

1313
/*
@@ -15486,7 +15486,13 @@ function canHydrateTextInstance(instance, text, inRootOrSingleton) {
1548615486
}
1548715487
function canHydrateHydrationBoundary(instance, inRootOrSingleton) {
1548815488
for (; 8 !== instance.nodeType; ) {
15489-
if (!inRootOrSingleton) return null;
15489+
if (
15490+
(1 !== instance.nodeType ||
15491+
"INPUT" !== instance.nodeName ||
15492+
"hidden" !== instance.type) &&
15493+
!inRootOrSingleton
15494+
)
15495+
return null;
1549015496
instance = getNextHydratable(instance.nextSibling);
1549115497
if (null === instance) return null;
1549215498
}
@@ -17190,14 +17196,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1719017196
};
1719117197
var isomorphicReactPackageVersion$jscomp$inline_2023 = React.version;
1719217198
if (
17193-
"19.2.0-native-fb-090777d7-20250822" !==
17199+
"19.2.0-native-fb-9c2e2b84-20250827" !==
1719417200
isomorphicReactPackageVersion$jscomp$inline_2023
1719517201
)
1719617202
throw Error(
1719717203
formatProdErrorMessage(
1719817204
527,
1719917205
isomorphicReactPackageVersion$jscomp$inline_2023,
17200-
"19.2.0-native-fb-090777d7-20250822"
17206+
"19.2.0-native-fb-9c2e2b84-20250827"
1720117207
)
1720217208
);
1720317209
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17219,10 +17225,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1721917225
};
1722017226
var internals$jscomp$inline_2554 = {
1722117227
bundleType: 0,
17222-
version: "19.2.0-native-fb-090777d7-20250822",
17228+
version: "19.2.0-native-fb-9c2e2b84-20250827",
1722317229
rendererPackageName: "react-dom",
1722417230
currentDispatcherRef: ReactSharedInternals,
17225-
reconcilerVersion: "19.2.0-native-fb-090777d7-20250822"
17231+
reconcilerVersion: "19.2.0-native-fb-9c2e2b84-20250827"
1722617232
};
1722717233
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1722817234
var hook$jscomp$inline_2555 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17320,4 +17326,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1732017326
listenToAllSupportedEvents(container);
1732117327
return new ReactDOMHydrationRoot(initialChildren);
1732217328
};
17323-
exports.version = "19.2.0-native-fb-090777d7-20250822";
17329+
exports.version = "19.2.0-native-fb-9c2e2b84-20250827";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js‎

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<81fe96dd03a39bd29128c49e619f739b>>
10+
* @generated SignedSource<<e782acb6c2e5c1d8b944e7152f60fb96>>
1111
*/
1212

1313
/*
@@ -17487,7 +17487,13 @@ function canHydrateTextInstance(instance, text, inRootOrSingleton) {
1748717487
}
1748817488
function canHydrateHydrationBoundary(instance, inRootOrSingleton) {
1748917489
for (; 8 !== instance.nodeType; ) {
17490-
if (!inRootOrSingleton) return null;
17490+
if (
17491+
(1 !== instance.nodeType ||
17492+
"INPUT" !== instance.nodeName ||
17493+
"hidden" !== instance.type) &&
17494+
!inRootOrSingleton
17495+
)
17496+
return null;
1749117497
instance = getNextHydratable(instance.nextSibling);
1749217498
if (null === instance) return null;
1749317499
}
@@ -19200,14 +19206,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1920019206
};
1920119207
var isomorphicReactPackageVersion$jscomp$inline_2274 = React.version;
1920219208
if (
19203-
"19.2.0-native-fb-090777d7-20250822" !==
19209+
"19.2.0-native-fb-9c2e2b84-20250827" !==
1920419210
isomorphicReactPackageVersion$jscomp$inline_2274
1920519211
)
1920619212
throw Error(
1920719213
formatProdErrorMessage(
1920819214
527,
1920919215
isomorphicReactPackageVersion$jscomp$inline_2274,
19210-
"19.2.0-native-fb-090777d7-20250822"
19216+
"19.2.0-native-fb-9c2e2b84-20250827"
1921119217
)
1921219218
);
1921319219
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19229,10 +19235,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1922919235
};
1923019236
var internals$jscomp$inline_2281 = {
1923119237
bundleType: 0,
19232-
version: "19.2.0-native-fb-090777d7-20250822",
19238+
version: "19.2.0-native-fb-9c2e2b84-20250827",
1923319239
rendererPackageName: "react-dom",
1923419240
currentDispatcherRef: ReactSharedInternals,
19235-
reconcilerVersion: "19.2.0-native-fb-090777d7-20250822",
19241+
reconcilerVersion: "19.2.0-native-fb-9c2e2b84-20250827",
1923619242
getLaneLabelMap: function () {
1923719243
for (
1923819244
var map = new Map(), lane = 1, index$321 = 0;
@@ -19346,4 +19352,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1934619352
listenToAllSupportedEvents(container);
1934719353
return new ReactDOMHydrationRoot(initialChildren);
1934819354
};
19349-
exports.version = "19.2.0-native-fb-090777d7-20250822";
19355+
exports.version = "19.2.0-native-fb-9c2e2b84-20250827";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-dev.js‎

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<805d04ba8044b5251ba8a45d070a2bce>>
10+
* @generated SignedSource<<97bc02c79afef9108bad96c3b21df04e>>
1111
*/
1212

1313
/*
@@ -23592,7 +23592,13 @@ __DEV__ &&
2359223592
}
2359323593
function canHydrateHydrationBoundary(instance, inRootOrSingleton) {
2359423594
for (; 8 !== instance.nodeType; ) {
23595-
if (!inRootOrSingleton) return null;
23595+
if (
23596+
(1 !== instance.nodeType ||
23597+
"INPUT" !== instance.nodeName ||
23598+
"hidden" !== instance.type) &&
23599+
!inRootOrSingleton
23600+
)
23601+
return null;
2359623602
instance = getNextHydratable(instance.nextSibling);
2359723603
if (null === instance) return null;
2359823604
}
@@ -29423,11 +29429,11 @@ __DEV__ &&
2942329429
};
2942429430
(function () {
2942529431
var isomorphicReactPackageVersion = React.version;
29426-
if ("19.2.0-native-fb-090777d7-20250822" !== isomorphicReactPackageVersion)
29432+
if ("19.2.0-native-fb-9c2e2b84-20250827" !== isomorphicReactPackageVersion)
2942729433
throw Error(
2942829434
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2942929435
(isomorphicReactPackageVersion +
29430-
"\n - react-dom: 19.2.0-native-fb-090777d7-20250822\nLearn more: https://react.dev/warnings/version-mismatch")
29436+
"\n - react-dom: 19.2.0-native-fb-9c2e2b84-20250827\nLearn more: https://react.dev/warnings/version-mismatch")
2943129437
);
2943229438
})();
2943329439
("function" === typeof Map &&
@@ -29464,10 +29470,10 @@ __DEV__ &&
2946429470
!(function () {
2946529471
var internals = {
2946629472
bundleType: 1,
29467-
version: "19.2.0-native-fb-090777d7-20250822",
29473+
version: "19.2.0-native-fb-9c2e2b84-20250827",
2946829474
rendererPackageName: "react-dom",
2946929475
currentDispatcherRef: ReactSharedInternals,
29470-
reconcilerVersion: "19.2.0-native-fb-090777d7-20250822"
29476+
reconcilerVersion: "19.2.0-native-fb-9c2e2b84-20250827"
2947129477
};
2947229478
internals.overrideHookState = overrideHookState;
2947329479
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -29922,7 +29928,7 @@ __DEV__ &&
2992229928
exports.useFormStatus = function () {
2992329929
return resolveDispatcher().useHostTransitionStatus();
2992429930
};
29925-
exports.version = "19.2.0-native-fb-090777d7-20250822";
29931+
exports.version = "19.2.0-native-fb-9c2e2b84-20250827";
2992629932
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
2992729933
"function" ===
2992829934
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-prod.js‎

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<f068459c1af5b90b1c96348004a3a190>>
10+
* @generated SignedSource<<b5ceb7a960e8ef2928d6cf0e3d8f5b65>>
1111
*/
1212

1313
/*
@@ -15486,7 +15486,13 @@ function canHydrateTextInstance(instance, text, inRootOrSingleton) {
1548615486
}
1548715487
function canHydrateHydrationBoundary(instance, inRootOrSingleton) {
1548815488
for (; 8 !== instance.nodeType; ) {
15489-
if (!inRootOrSingleton) return null;
15489+
if (
15490+
(1 !== instance.nodeType ||
15491+
"INPUT" !== instance.nodeName ||
15492+
"hidden" !== instance.type) &&
15493+
!inRootOrSingleton
15494+
)
15495+
return null;
1549015496
instance = getNextHydratable(instance.nextSibling);
1549115497
if (null === instance) return null;
1549215498
}
@@ -17201,14 +17207,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1720117207
};
1720217208
var isomorphicReactPackageVersion$jscomp$inline_2024 = React.version;
1720317209
if (
17204-
"19.2.0-native-fb-090777d7-20250822" !==
17210+
"19.2.0-native-fb-9c2e2b84-20250827" !==
1720517211
isomorphicReactPackageVersion$jscomp$inline_2024
1720617212
)
1720717213
throw Error(
1720817214
formatProdErrorMessage(
1720917215
527,
1721017216
isomorphicReactPackageVersion$jscomp$inline_2024,
17211-
"19.2.0-native-fb-090777d7-20250822"
17217+
"19.2.0-native-fb-9c2e2b84-20250827"
1721217218
)
1721317219
);
1721417220
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17230,10 +17236,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1723017236
};
1723117237
var internals$jscomp$inline_2557 = {
1723217238
bundleType: 0,
17233-
version: "19.2.0-native-fb-090777d7-20250822",
17239+
version: "19.2.0-native-fb-9c2e2b84-20250827",
1723417240
rendererPackageName: "react-dom",
1723517241
currentDispatcherRef: ReactSharedInternals,
17236-
reconcilerVersion: "19.2.0-native-fb-090777d7-20250822"
17242+
reconcilerVersion: "19.2.0-native-fb-9c2e2b84-20250827"
1723717243
};
1723817244
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1723917245
var hook$jscomp$inline_2558 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17484,4 +17490,4 @@ exports.useFormState = function (action, initialState, permalink) {
1748417490
exports.useFormStatus = function () {
1748517491
return ReactSharedInternals.H.useHostTransitionStatus();
1748617492
};
17487-
exports.version = "19.2.0-native-fb-090777d7-20250822";
17493+
exports.version = "19.2.0-native-fb-9c2e2b84-20250827";

0 commit comments

Comments
 (0)