Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address all the query related exception thrown by Bullet #1885

Open
7 tasks
asideofcode-dev opened this issue Jul 25, 2023 · 1 comment
Open
7 tasks

Address all the query related exception thrown by Bullet #1885

asideofcode-dev opened this issue Jul 25, 2023 · 1 comment

Comments

@asideofcode-dev
Copy link
Contributor

Description of the issue 📄

As part of the pull request to update to Rails 5, #1882, Bullet has started throwing exceptions on certain queries. For the moment we have set Bullet.raise = false in config/environments/test.rb. Bullet is still turned on it just logs any offences instead of raising exceptions.

Screenshots 📷

Steps to fix 🛠

Methodically go through all queries raising Bullet exceptions, and address the issue. It's almost always something to do with n+1 queries or eager loading.

To do 📋

  • Claim this issue (comment below, or assign yourself if you are part of the codebar org)
  • Fork and clone the repository
  • Update the relevant files. Follow the steps to fix section in this issue.
  • Commit your changes as one commit. Use the title of this issue as your commit message
  • Submit a pull request
  • Mention this issue in the PR description by including it's number
  • Have your pull request reviewed & merged by a codebar team member
@asideofcode-dev asideofcode-dev changed the title Methodically address all the Bullet issues Address all the query related exception thrown by Bullet Jul 25, 2023
@gnclmorais
Copy link
Contributor

Definitely, a long time ago I looked into a few of these queries, while I was trying to update Rails version. Have you heard of query_diet as well? I read some interesting things about it…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants