Skip to content

Commit add4d26

Browse files
committed
Fixed some issues that came up during review
1 parent c64ef0b commit add4d26

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

Symfony/src/Codebender/CompilerBundle/Controller/DefaultController.php

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public function deleteAllObjectsAction($authorizationKey, $version)
9191

9292
$response = $deleter->deleteAllObjects();
9393

94-
if ($response['success'] === false) {
94+
if ($response['success'] !== true) {
9595
return new Response(json_encode(
9696
array('success' => false, 'step' => 0, 'message' => 'Failed to access object files directory.')
9797
));
@@ -128,20 +128,28 @@ public function deleteSpecificObjectsAction($authorizationKey, $version, $option
128128

129129
$response = $deleter->deleteSpecificObjects($option, $cachedObjectToDelete);
130130

131-
if ($response['success'] === false) {
131+
if ($response['success'] !== true) {
132132
return new Response(json_encode(
133133
array('success' => false, 'step' => 0, 'message' => 'Failed to access object files directory.')
134134
));
135135
}
136136

137-
if ($response["notDeletedFiles"] != '') {
138-
$message = ($option == 'library') ? 'Failed to delete one or more of the specified library object files.' : 'Failed to delete one or more of the specified core object files.';
137+
if (!empty($response["notDeletedFiles"])) {
138+
$message = 'Failed to delete one or more of the specified core object files.';
139+
if ($option == 'library') {
140+
$message = 'Failed to delete one or more of the specified library object files.';
141+
}
142+
139143
return new Response(json_encode(
140144
array_merge(array('success' => false, 'step' => 0, 'message' => $message), $response)
141145
));
142146
}
143147

144-
$message = ($option == 'library') ? 'Library deleted successfully.' : 'Core object files deleted successfully.';
148+
$message = 'Core object files deleted successfully.';
149+
if ($option == 'library'){
150+
$message = 'Library deleted successfully.';
151+
}
152+
145153
return new Response(json_encode(array_merge(array('success' => true, 'message' => $message), $response)));
146154
}
147155

0 commit comments

Comments
 (0)