Skip to content

Conversation

@watchtheblur
Copy link
Member

@watchtheblur watchtheblur commented Aug 20, 2020

Background/Context

Postman collection didn't have entry for search

Before and After

Added search GET to collection

Acknowledgments (optional)

Thanks to Linda for the screenshot!

Other notes (optional)

resolves issue #149

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@c33995d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage        ?   83.78%           
=======================================
  Files           ?       32           
  Lines           ?      518           
  Branches        ?        0           
=======================================
  Hits            ?      434           
  Misses          ?       84           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c33995d...1e4e583. Read the comment docs.

@BethanyG BethanyG requested a review from lpatmo August 20, 2020 05:06
@BethanyG
Copy link
Member

@lpatmo tagging you as the reviewer here, since you're our resident Postman expert!

@watchtheblur watchtheblur linked an issue Aug 26, 2020 that may be closed by this pull request
@BethanyG BethanyG requested a review from lpatmo September 4, 2020 07:08
Copy link
Member

@lpatmo lpatmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@watchtheblur Thanks for making the changes! I imported the updated version into Postman and everything looks great 🔥🔥

The only bug I noticed is that CREATE resource needs a media_type added:
image

... but this is something we can address in another issue instead of fixing in this one, certainly.

@lpatmo
Copy link
Member

lpatmo commented Sep 5, 2020

I'm going to merge this in and file a new issue for the the media_type issue :)

@lpatmo lpatmo merged commit 551d43e into codebuddies:main Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tooling] Add GET endpoint for search to POSTMAN

3 participants