Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

it's required fields that should not exceed 300, not optional + required #392

Closed
ildar-shaymukhametov opened this issue Mar 15, 2022 · 3 comments · Fixed by #498
Closed

it's required fields that should not exceed 300, not optional + required #392

ildar-shaymukhametov opened this issue Mar 15, 2022 · 3 comments · Fixed by #498

Comments

@ildar-shaymukhametov
Copy link

did you read https://sbqr.ru/standard/files/standart.pdf?

it's required fields that should not exceed 300, not optional + required

QRCoder/QRCoder/PayloadGenerator.cs

Line 2531 in cecf206

if (bytesOut.Length > 300)

please fix asap
@ildar-shaymukhametov
Copy link
Author

ildar-shaymukhametov commented Mar 16, 2022 •
edited
Loading

Guuuys, it must be done asap, people waiting

@ildar-shaymukhametov
Copy link
Author

no, the spec says:
image
meaning only required fields should not exceed 300, meaning bytesOut should contain only required fields
it says nothing about optional fields

@ildar-shaymukhametov
Copy link
Author

about optional fields:
the spec says:
image
meaning what free space remains may be used by optional fields

@codebude codebude mentioned this issue Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/392 fix and improve payment payload generator validation codebude/QRCoder
1 participant
@ildar-shaymukhametov