Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate JavaMelody #388

Closed
wallishuang opened this issue Jan 16, 2017 · 7 comments
Closed

integrate JavaMelody #388

wallishuang opened this issue Jan 16, 2017 · 7 comments

Comments

@wallishuang
Copy link

wallishuang commented Jan 16, 2017

Integration with javamelody will be great...
https://github.com/javamelody/javamelody/wiki

@joshiste joshiste changed the title integrate with javamelody integrat JavaMelody Jan 16, 2017
@joshiste joshiste changed the title integrat JavaMelody integrate JavaMelody Jan 16, 2017
@Pughy12
Copy link

Pughy12 commented Feb 23, 2017

Is this still being looked into? I am really interested in this happening, just wondering how close (if at all) it is to becoming a reality.

@joshiste
Copy link
Collaborator

joshiste commented Feb 23, 2017

If you want to see this happen you need to do it yourself. Any help and PRs are appreciated. I have too limited time to dig into this.

@Pughy12
Copy link

Pughy12 commented Feb 23, 2017

Fair enough, thanks for the reply.

@dvtoever
Copy link

I have something which is kinda working, applications register itself using service discovery (eureka) to the javamelody collect server (which I added into my spring-boot-admin project). I also made a very basic spring-boot-admin-server-ui-javamelody module that embeds the specific javamelody page within an iframe (yes an iframe).

Is there interest if I share this as a pull request? It would be nice if others could help give it further shape

@joshiste
Copy link
Collaborator

Showing code is always appreciated :)

I wonder if we can make the collect-server use the ApplicationRegistry as source for collecting, so that sba-client and discovery are both supported....

@dvtoever
Copy link

Ok, i created a PR that is not intented to be merged right now, but to provide a starting point from which can be worked. #450

For now the service discovery events are used to register applications, I guess we can easily fit ApplicationRegistry into this as well

@joshiste
Copy link
Collaborator

There is now a solution for writing 3rd party view modules and also the backend is extensible. Therefore this integration should be developed as a 3rd party module (if ever done)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants