-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate JavaMelody #388
Comments
Is this still being looked into? I am really interested in this happening, just wondering how close (if at all) it is to becoming a reality. |
If you want to see this happen you need to do it yourself. Any help and PRs are appreciated. I have too limited time to dig into this. |
Fair enough, thanks for the reply. |
I have something which is kinda working, applications register itself using service discovery (eureka) to the javamelody collect server (which I added into my spring-boot-admin project). I also made a very basic spring-boot-admin-server-ui-javamelody module that embeds the specific javamelody page within an iframe (yes an iframe). Is there interest if I share this as a pull request? It would be nice if others could help give it further shape |
Showing code is always appreciated :) I wonder if we can make the collect-server use the ApplicationRegistry as source for collecting, so that sba-client and discovery are both supported.... |
Ok, i created a PR that is not intented to be merged right now, but to provide a starting point from which can be worked. #450 For now the service discovery events are used to register applications, I guess we can easily fit ApplicationRegistry into this as well |
There is now a solution for writing 3rd party view modules and also the backend is extensible. Therefore this integration should be developed as a 3rd party module (if ever done) |
Integration with javamelody will be great...
https://github.com/javamelody/javamelody/wiki
The text was updated successfully, but these errors were encountered: