Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing description of Parameters in JMX operations #531

Closed
frkautz opened this issue Aug 23, 2017 · 5 comments
Closed

Missing description of Parameters in JMX operations #531

frkautz opened this issue Aug 23, 2017 · 5 comments

Comments

@frkautz
Copy link

frkautz commented Aug 23, 2017

I upgraded the spring-boot-admin-server and spring-boot-admin-server-ui from 1.3.7 to 1.5.3. In our services (spring-boot-admin-starter-client) we use 1.3.x, 1.4.x. and 1.5.x. In the spring boot admin server UI we are missing the description of the parameters from all JMX operations. This happens with our JMX operations and also with the operations from java.lang and other domains. We have the issues with all services, so I think it is an issue in the spring-boot-admin-server or spring-boot-admin-server-ui. The two attached screenshots shows the JMX operations in the UI in the different UI versions.
jmx_endpoint_sba_1 3 7
jmx_endpoint_sba_1 5 3

The relevant code snippet:

@ManagedOperationParameters({
        @ManagedOperationParameter(name = "accountId", description = "The id of the accountuser aggregate"),
        @ManagedOperationParameter(name = "legalTermsLockReason", description = "Reason for legal terms lock (BOUNCE, CANCELLATION")
})
public void setLegalTermsLock(String accountId, String legalTermsLockReason) {
       …
}
@joshiste
Copy link
Collaborator

Yes indeed. The description is gone missing.

@joshiste
Copy link
Collaborator

I'll target that for the next release

@joshiste joshiste added this to the 1.5.4 milestone Aug 23, 2017
@frkautz
Copy link
Author

frkautz commented Sep 12, 2017

Hi joshiste,

I tested the version 1.5.4, but the issue isn't gone. Can you reopen the ticket.

kind regards,
Frank

@joshiste
Copy link
Collaborator

@frkautz Did you have a look into the jolokia response if the description is provided by jolokia? (and made sure you didn't had an old version from browser cache)?

@frkautz
Copy link
Author

frkautz commented Sep 12, 2017

@joshiste somehow a strange behavior after I deleted the browser cache it didn't work, but during analyzing the jolokia request it shows the description. So ignore my request to reopen the ticket. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants