Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

400 on Patch when clippling https://www.forkknifeswoon.com/simple-homemade-chicken-ramen/ #7

Closed
angelo-v opened this issue Oct 11, 2021 · 6 comments
Labels
bug Something isn't working
Milestone

Comments

@angelo-v
Copy link
Collaborator

Trying to clip from https://www.forkknifeswoon.com/simple-homemade-chicken-ramen/ results in:

Patch document syntax error: Line 1 of <https://angelo.veltens.org/webclip/2021/10/11/55a6d21e-2aa8-44ca-bff9-457dc2b00195>: Bad syntax:
   Unknown syntax at start of statememt: '[object Object]'
   at: "[object Object]"
@angelo-v angelo-v added the bug Something isn't working label Oct 11, 2021
@angelo-v angelo-v added this to the 0.5.0 milestone Oct 11, 2021
@angelo-v
Copy link
Collaborator Author

The page in question contains JSON-LD literals with \r\n\r\n characters, which I guess is fine, but somehow the rdflib updater messes thisi up to an invalid SPARQL Update command including real line breaks in literal values. This needs to be fixed in rdflib.

Besides that the page data is really huge, there might be other issues that need investigation after the rdflib fix

@angelo-v
Copy link
Collaborator Author

rdflib issue: linkeddata/rdflib.js#517

@angelo-v
Copy link
Collaborator Author

after removing the carriage returns I could successfully clip the page data to a locally running instance of CSS. Clipping to NSS failed, but that might be because NSS is just not capable of receiving a sparql insert with > 10000 statements

@angelo-v
Copy link
Collaborator Author

I upgraded rdflib, on NSS it still does not work (as expected, see above). Needs to be tested on CSS, e.g. https://solidweb.me, which is currently down for maintainance

@angelo-v
Copy link
Collaborator Author

Successfully tested on CSS at https://solidweb.me

@angelo-v
Copy link
Collaborator Author

Possible follow up: If NSS sent 413 we could split large requests into multiple ones as needed. nodeSolidServer/node-solid-server#1628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant