Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use singular/plural only in API resources #81

Open
nuest opened this issue Jul 17, 2024 · 4 comments
Open

Use singular/plural only in API resources #81

nuest opened this issue Jul 17, 2024 · 4 comments
Assignees
Labels
development Development of the register Waiting to merge

Comments

@nuest
Copy link
Member

nuest commented Jul 17, 2024

Currently there is "venues" but "community", "codecheckers" but "journal".

@nuest nuest added the development Development of the register label Jul 17, 2024
@nuest nuest added this to the CHECK-NL pre Twente Workshop milestone Jul 17, 2024
@angelina-momin angelina-momin added work in progress a codechecker is assigned and working on the check and removed work in progress a codechecker is assigned and working on the check labels Sep 5, 2024
@angelina-momin
Copy link
Collaborator

@nuest Do you have a preference for any particular API type? Since REST API is the most common API type I am thinking of implementing plural API resources which is the REST API's convention.

@nuest
Copy link
Member Author

nuest commented Sep 16, 2024

@angelina-momin Yes, plural because of REST convention is fine.

@angelina-momin
Copy link
Collaborator

angelina-momin commented Sep 16, 2024

@nuest and do you want to keep "register" as "register" or "registers" in
"https://codecheck.org.uk/register/venues/journal/"

But then if pluralized not sure what to do with "register" here:
"https://codecheck.org.uk/register/"

If you do want me to change that, I am not sure how to change it- is it renaming the "register" folder itself?

@nuest
Copy link
Member Author

nuest commented Sep 16, 2024

There will ever only be one register, that one should stay singular.

@angelina-momin angelina-momin added work in progress a codechecker is assigned and working on the check Waiting to merge and removed work in progress a codechecker is assigned and working on the check labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Development of the register Waiting to merge
Projects
None yet
Development

No branches or pull requests

2 participants