-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Actions isFork
False Positive
#80
Comments
This was referenced May 5, 2021
It should be fixed in: #81 beta released as: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am observing an error running
codechecks
in Github Actions -Provider should never be in fork mode and not in PR mode!
It appears as if there is a false positive as the PR is not coming from a fork. The code is here:
monorepo/packages/client/src/getExecutionContext.ts
Lines 20 to 25 in 13986fe
For Github actions,
!pr
is always truemonorepo/packages/client/src/ci-providers/GithubActions.ts
Lines 14 to 16 in ba52ad8
And
isFork
is always true becauseGITHUB_HEAD_REF
is set for PRs submitted from the same repo. See the docs here: https://docs.github.com/en/actions/reference/environment-variablesmonorepo/packages/client/src/ci-providers/GithubActions.ts
Lines 27 to 31 in ba52ad8
Perhaps there is a better way to determine there the PR is coming from a fork, will update if I determine a good solution
The text was updated successfully, but these errors were encountered: