Skip to content

Commit c3ca9c1

Browse files
committed
Merge pull request #26 from codeclimate/will/smaller-image
Smaller Image, minor build improvements
2 parents e31796f + 14615d1 commit c3ca9c1

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

Dockerfile

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
FROM node
2-
3-
MAINTAINER Michael R. Bernstein
1+
FROM node:5.5-slim
2+
MAINTAINER Michael R. Bernstein <mrb@codeclimate.com>
43

54
WORKDIR /usr/src/app/
65

Makefile

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
.PHONY: image test
2+
3+
IMAGE_NAME ?= codeclimate/codeclimate-fixme
4+
5+
image:
6+
docker build --rm -t $(IMAGE_NAME) .
7+
8+
test: image
9+
docker run --rm $(IMAGE_NAME) npm test

circle.yml

+2-4
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,11 @@ machine:
99
CODECLIMATE_DOCKER_REGISTRY_EMAIL: ops@codeclimate.com
1010

1111
dependencies:
12-
override:
13-
- docker build -t=$PRIVATE_REGISTRY/$CIRCLE_PROJECT_REPONAME:b$CIRCLE_BUILD_NUM .
14-
- npm install
12+
override: #no-op
1513

1614
test:
1715
override:
18-
- npm test
16+
- IMAGE_NAME="$PRIVATE_REGISTRY/$CIRCLE_PROJECT_REPONAME:b$CIRCLE_BUILD_NUM" make test
1917

2018
deployment:
2119
registry:

0 commit comments

Comments
 (0)