Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the rubocop engines to include rubocop-0-68, rubocop-0-69 and… #915

Closed
wants to merge 1 commit into from

Conversation

tchia04
Copy link

@tchia04 tchia04 commented May 31, 2019

… rubocop-0-70

This should allow using the following in .codecliate.yml

version: "2"
plugins:
  rubocop:
    enabled: true
#    channel: "rubocop-0-68"
#    channel: "rubocop-0-69"
    channel: "rubocop-0-70"

Current unable to pull down any image after 67
$ codeclimate engines:install
Pulling docker images.
.....
WARNING: unknown engine rubocop:rubocop-0-70

I see rubocop-0-70 at https://hub.docker.com/r/codeclimate/codeclimate-rubocop/tags

@CLAassistant
Copy link

CLAassistant commented May 31, 2019

CLA assistant check
All committers have signed the CLA.

@alaxalves
Copy link

I really could use that. \o/

@efueger
Copy link
Contributor

efueger commented May 31, 2019

Thanks for the heads up @tchia04! I'll notify the team.

@tchia04
Copy link
Author

tchia04 commented Jun 1, 2019

Also, Could you also update the latest docker image tag to this?
rubocop-0-70 33 MB
Last update: 4 days ago

Currently it's pointing to this

latest 34 MB
Last update: 2 months ago

@maxjacobson
Copy link
Contributor

We've just got this new release with the new RuboCop channels: https://github.com/codeclimate/codeclimate/releases/tag/v0.85.3 (Thanks @filipesperandio for your hard work preparing all of these channels).

@tchia04:

Using newer RuboCops on Code Climate requires opting in to the channel. If you don't opt into a channel, you'll continue to get RubooCop 0.52, which is the version on our master branch for that plugin. There are many repositories using RuboCop via Code Climate without specifying a channel, and with a .rubocop.yml which is committed to the repository. If we change the default RuboCop to a newer one, their builds may start failing. It's not ideal, and we'd like to chart a path toward changing the default RuboCop to a modern version, but it's a little tricky. Just sharing the context for the sake of transparency. We appreciate the nudge.

@maxjacobson maxjacobson closed this Jun 5, 2019
@alaxalves
Copy link

We've just got this new release with the new RuboCop channels: https://github.com/codeclimate/codeclimate/releases/tag/v0.85.3 (Thanks @filipesperandio for your hard work preparing all of these channels).

@tchia04:

Using newer RuboCops on Code Climate requires opting in to the channel. If you don't opt into a channel, you'll continue to get RubooCop 0.52, which is the version on our master branch for that plugin. There are many repositories using RuboCop via Code Climate without specifying a channel, and with a .rubocop.yml which is committed to the repository. If we change the default RuboCop to a newer one, their builds may start failing. It's not ideal, and we'd like to chart a path toward changing the default RuboCop to a modern version, but it's a little tricky. Just sharing the context for the sake of transparency. We appreciate the nudge.

Sorry but I don't quite get this. So just by doing something like:

version: 2
plugins:
  rubocop:
    enabled: true
    channel: rubocop-0-70

I'll be able to use rubocop version 0.70.0 along with CodeClimate?

@maxjacobson
Copy link
Contributor

Yep, precisely. You can learn more about channels here: https://docs.codeclimate.com/docs/engine-channels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants