-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing semaphore environmental variable #484
Comments
(Our status updates had been hanging for months. I identified this problem today and was able to implement a workaround in semaphore, but this should fix problems for anyone using this integration). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sorry I'm too lazy to write a PR for this, but the following from
env/git.go
......contains a nice pattern for semaphore by listing these two in order:
"SEMAPHORE_GIT_PR_BRANCH", "SEMAPHORE_GIT_BRANCH"
.However the same is not true for the commit shas:
This leads to problems with pull request status updates on code climate, because semaphore is using the merge sha rather than the pr's head sha. (see https://docs.semaphoreci.com/essentials/project-workflow-trigger-options/)
If you were to add
"SEMAPHORE_GIT_PR_SHA"
immediately before"SEMAPHORE_GIT_SHA"
, this would solve that problem (and better parallel the branch handling).The text was updated successfully, but these errors were encountered: