Overwrite the commit on pull_request* events #244

thomasrockhu · 2021-03-08T23:42:43Z

On pull_request* events (pull_request, pull_request_target) using the actions/checkout step, GitHub Actions creates a detached HEAD SHA. This SHA is what gets sent to Codecov as opposed to the true HEAD SHA. The change ensures that the underlying uploader receives the correct SHA based on the GitHub context.

This change will allow for usage of this Action without adding fetch-depth to the checkout step by overwriting the detached SHA with the HEAD SHA

codecov · 2021-03-08T23:47:55Z

Codecov Report

Merging #244 (65f43ce) into master (ca774cf) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
+ Coverage   97.67%   97.77%   +0.10%     
==========================================
  Files           3        3              
  Lines         129      135       +6     
  Branches       38       41       +3     
==========================================
+ Hits          126      132       +6     
  Misses          3        3

Flag	Coverage Δ
demo	`87.50% <ø> (ø)`
script	`99.15% <100.00%> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/buildExec.ts	`99.15% <100.00%> (+0.04%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca774cf...65f43ce. Read the comment docs.

drazisil-codecov

Can you please edit the PR description explaining what these changes do? I think that would be a good process to start as some of these changes can be quite confusing. Would be very helpful for both reviewers and other viewers o this PR. (also helps when searching) :)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from v1.2.1 to v1.3.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p> <blockquote> <h2>v1.3.1</h2> <h2>1.3.1</h2> <h3>Fixes</h3> <ul> <li><a href="https://github.com/codecov/codecov-action/issues/253">#253</a> Add <code>network_filter</code> to action manifest</li> </ul> <h2>v1.3.0</h2> <h2>1.3.0</h2> <h3>Features</h3> <ul> <li><a href="https://github.com/codecov/codecov-action/issues/252">#252</a> Add "network_filter" input</li> </ul> <h2>v1.2.2</h2> <h3>Fixes</h3> <ul> <li><a href="https://github.com/codecov/codecov-action/issues/241">#241</a> pass root_dir using proper bash arg</li> <li><a href="https://github.com/codecov/codecov-action/issues/244">#244</a> Overwrite the commit on pull_request* events</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md">codecov/codecov-action's changelog</a>.</em></p> <blockquote> <h2>1.3.1</h2> <h3>Fixes</h3> <ul> <li><a href="https://github.com/codecov/codecov-action/issues/253">#253</a> Add <code>network_filter</code> to action manifest</li> </ul> <h2>1.3.0</h2> <h3>Features</h3> <ul> <li><a href="https://github.com/codecov/codecov-action/issues/252">#252</a> Add "network_filter" input</li> </ul> <h2>1.2.2</h2> <h3>Fixes</h3> <ul> <li><a href="https://github.com/codecov/codecov-action/issues/241">#241</a> pass root_dir using proper bash arg</li> <li><a href="https://github.com/codecov/codecov-action/issues/244">#244</a> Overwrite the commit on pull_request* events</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/codecov/codecov-action/commit/fcebab03f26c7530a22baa63f06b3e0515f0c7cd"><code>fcebab0</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/253">#253</a> from codecov/1.3.1</li> <li><a href="https://github.com/codecov/codecov-action/commit/7ea3ba9ac075d6b603dc17b37e2984a5fda6843b"><code>7ea3ba9</code></a> Add network_filter to manifest</li> <li><a href="https://github.com/codecov/codecov-action/commit/6ed0d16b40c7d9a556bd123f0e7253be6ed081df"><code>6ed0d16</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/252">#252</a> from codecov/1.3.0</li> <li><a href="https://github.com/codecov/codecov-action/commit/79a0ba12c830bcfe66179a421069b588cb277952"><code>79a0ba1</code></a> Add network filter parameter</li> <li><a href="https://github.com/codecov/codecov-action/commit/1f8f3abcccf7960749744fd13547965f0e7d1bdd"><code>1f8f3ab</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/247">#247</a> from codecov/1.2.2</li> <li><a href="https://github.com/codecov/codecov-action/commit/763298c6f68b6b2d4191362e8da948ad180b4299"><code>763298c</code></a> Update CHANGELOG.md</li> <li><a href="https://github.com/codecov/codecov-action/commit/3207ad4e6013c331c40ac815c772d6e9714f5f77"><code>3207ad4</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/241">#241</a> from jeffkenney/fix-root-dir-arg</li> <li><a href="https://github.com/codecov/codecov-action/commit/ab3cfafc5bac7280958384264e1b954433cce9a7"><code>ab3cfaf</code></a> Bump to 1.2.2</li> <li><a href="https://github.com/codecov/codecov-action/commit/b708b7e81f3f8e04728cc8e1b1ad83735f01101f"><code>b708b7e</code></a> Merge pull request <a href="https://github.com/codecov/codecov-action/issues/244">#244</a> from codecov/override-fetch-depth</li> <li><a href="https://github.com/codecov/codecov-action/commit/65f43cece2c52d3e87256602f328dc0cdd5ef4df"><code>65f43ce</code></a> actually</li> <li>Additional commits viewable in <a href="https://github.com/codecov/codecov-action/compare/v1.2.1...fcebab03f26c7530a22baa63f06b3e0515f0c7cd">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

thomasrockhu added 3 commits March 8, 2021 18:42

Try forcing the commit

482a905

Add actions/github

6a50e68

Fix tests

71a6279

thomasrockhu added 7 commits March 8, 2021 19:03

output context

ddfe212

Do commit SHA edit for pull_request*

e77dab6

Dont need event

50212c9

payload

87fff2e

Fix test

227f879

Actually update tests

21a1e29

actually

65f43ce

thomasrockhu requested a review from a team March 9, 2021 00:33

thomasrockhu marked this pull request as ready for review March 9, 2021 00:33

thomasrockhu changed the title ~~Try forcing the commit~~ Overwrite the commit on pull_request* events Mar 9, 2021

drazisil-codecov approved these changes Mar 9, 2021

View reviewed changes

drazisil-codecov mentioned this pull request Mar 9, 2021

Do not fix merge SHA if commit override codecov/codecov-bash#414

Merged

thomasrockhu merged commit b708b7e into master Mar 9, 2021

thomasrockhu mentioned this pull request Mar 9, 2021

Bump to 1.2.2 #247

Merged

petrsvihlik mentioned this pull request Mar 25, 2021

Action fails to upload when using pull_request_target on GitHub #155

Closed

thomasrockhu deleted the override-fetch-depth branch March 25, 2021 15:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Overwrite the commit on pull_request* events #244

Overwrite the commit on pull_request* events #244

thomasrockhu commented Mar 8, 2021 •

edited

Loading

codecov bot commented Mar 8, 2021 •

edited

Loading

drazisil-codecov left a comment

Overwrite the commit on pull_request* events #244

Overwrite the commit on pull_request* events #244

Conversation

thomasrockhu commented Mar 8, 2021 • edited Loading

codecov bot commented Mar 8, 2021 • edited Loading

Codecov Report

drazisil-codecov left a comment

Choose a reason for hiding this comment

thomasrockhu commented Mar 8, 2021 •

edited

Loading

codecov bot commented Mar 8, 2021 •

edited

Loading