Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for windows #7

Closed
mstoykov opened this issue Aug 19, 2019 · 3 comments
Closed

Support for windows #7

mstoykov opened this issue Aug 19, 2019 · 3 comments

Comments

@mstoykov
Copy link

Given that github can run windows (and macOs) builds on top of linux, it will be nice if the official codecov action can run on all three.

I see that there is codecov-exe , so I suppose this is being worked on ?

@adam7
Copy link

adam7 commented Sep 8, 2019

Same for macOS so I don't think codecov.exe will resolve the issue.

Build failure is because this is a Docker Action which are only supported on Linux. Porting to a JavaScript Action would resolve the issue because they are supported on Windows, macOS and Linux.

https://help.github.com/en/articles/about-actions#types-of-actions

@ibrahim0814
Copy link
Contributor

Hi all,

Thank you for bringing this up. I've updated our README to reflect this particular caveat. GitHub currently allows us to build two types of Actions - Docker and JS. We decided to use a Docker action since it allows us to wrap our bash uploader because our bash uploader is the only uploader the Codecov staff actively maintains. Of course, this comes at the cost of sacrificing Windows and macOS build capabilities.

Perhaps in the future, we will support these other operating systems, but for the time being, I do apologize that this action's functionality is limited to only Linux

Ib

@ibrahim0814
Copy link
Contributor

Hi all,

We've ported our action over to JavaScript as of release v1.0.4, so we can ensure that it now works on macOS, Windows, and Linux. Feel free to use it on your Windows builds :)

Ib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants