Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecovcli upload doesn't use correct codecov.yml #548

Open
Ryang20718 opened this issue Oct 31, 2024 · 5 comments
Open

codecovcli upload doesn't use correct codecov.yml #548

Ryang20718 opened this issue Oct 31, 2024 · 5 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months

Comments

@Ryang20718
Copy link

codecov processing for patch coverage results doesn't seem to respect the actual codecov.yml file uploaded

example repro: Ryang20718/cflag#17

However, the yaml file uploaded to codecov seems to be different from the one I had specified in my CI pipeline
https://app.codecov.io/gh/Ryang20718/cflag/commit/72810cf6efb3243205bf6daf24c58af789f359c4

Image

Is there some sort of cache going on?

codecov upload run https://github.com/Ryang20718/cflag/actions/runs/11620035443/job/32360963982?pr=17

@drazisil-codecov
Copy link
Contributor

This is not exactly a bug, since we only use the uploaded codecov.yml for label analysis and still pull from the repo to get the one we use for coverage. (I think)

@aj-codecov / @rohan-at-sentry How do you want to handle this? Docs? Behavior change? Bug?

@drazisil-codecov drazisil-codecov added bug Something isn't working documentation Improvements or additions to documentation labels Nov 1, 2024
@Ryang20718
Copy link
Author

Ryang20718 commented Nov 1, 2024

@drazisil-codecov it would be great if there could be an option to overwrite the uploaded codecov.yml.

still pull from the repo

does that mean we have to modify the repo codecov.yml if we wanted to somehow work around this limitation for now?

@drazisil-codecov
Copy link
Contributor

does that mean we have to modify the repo codecov.yml if we wanted to somehow work around this limitation for now?

That is correct. It needs to be checked into GitHub on the SHA that you are uploading coverage for.

@Ryang20718
Copy link
Author

Ryang20718 commented Nov 1, 2024

it would be great if codecov_yml_path uses the codecov yml passed in rather than repo!

@drazisil-codecov drazisil-codecov added the Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months label Nov 7, 2024
@thomasrockhu-codecov thomasrockhu-codecov added enhancement New feature or request and removed bug Something isn't working labels Nov 13, 2024
@thomasrockhu-codecov
Copy link
Contributor

@Ryang20718 I'll mark this as a feature request as this has not been the case. I can see how it's a little misleading that we have an argument for codecov_yml_path, but as @drazisil-codecov mentioned, it is not used when uploading coverage. You will still need to follow the guidelines here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request Medium Medium Priority Issues (to be fixed or re-evaluated in 3 months
Projects
None yet
Development

No branches or pull requests

3 participants