Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shared] (ref) Add total size compute for bundle analysis report #1067

Closed
Tracked by #1093
JerrySentry opened this issue Jan 19, 2024 · 1 comment
Closed
Tracked by #1093

[Shared] (ref) Add total size compute for bundle analysis report #1067

JerrySentry opened this issue Jan 19, 2024 · 1 comment
Assignees
@JerrySentry

Comments

@JerrySentry
Copy link

JerrySentry commented Jan 19, 2024 •
edited
Loading

Add a method in BundleAnalysisReport of shared repo to get the total size of all BundleReports. This will be used by worker and API to easily get the total bundle analysis size instead of calculating it individually

Finally, update the API code to use this method.
@JerrySentry JerrySentry mentioned this issue Jan 19, 2024
Closed
@JerrySentry JerrySentry self-assigned this Jan 19, 2024
@JerrySentry JerrySentry mentioned this issue Jan 23, 2024
Merged
@JerrySentry JerrySentry mentioned this issue Feb 12, 2024
Closed
@JerrySentry JerrySentry changed the title [Shared] Add total size compute for bundle analysis report [Shared] (ref) Add total size compute for bundle analysis report Feb 16, 2024
@JerrySentry JerrySentry removed their assignment Mar 15, 2024
@JerrySentry
Copy link
Author

Its faster for API to not use the shared computation. Worker PR comments doesn't use this helper function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JerrySentry JerrySentry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JerrySentry