Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: module mismatch #1856

Closed
Tracked by #1121
codecovdesign opened this issue Jun 5, 2024 · 7 comments
Closed
Tracked by #1121

bug: module mismatch #1856

codecovdesign opened this issue Jun 5, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@codecovdesign
Copy link
Contributor

codecovdesign commented Jun 5, 2024

Problem to solve

On the repo > bundle summary, it appears the module number is incorrect and/or needs to be reevaluated. In this example, the module count is 5 but looks at the assets > modules this appears to be mismatched.

Screenshot 2024-06-05 at 10 27 50 AM

Solution ideation

  • Investigate module count logic
    • what is determining module summary count and is it correct/incorrect?
    • from bug sync there was confusion about module/asset difference (maybe separate issue to address ux)
  • Intended behavior: match summary count with actual module
@codecovdesign codecovdesign added the bug Something isn't working label Jun 5, 2024
@nicholas-codecov
Copy link

nicholas-codecov commented Jun 12, 2024

@katia-sentry this is an API or worker ticket depending on the logic, and if we pre-calculate these values.

@katia-sentry
Copy link
Contributor

How are we defining modules @nicholas-codecov @JerrySentry ?

@nicholas-codecov
Copy link

I think it's in shared actually

@katia-sentry
Copy link
Contributor

Is this duplicate of #1925

@nicholas-codecov
Copy link

nicholas-codecov commented Jun 17, 2024

Not really, that one is for when the user filters, tho it could be shared, and override this? @JerrySentry can confirm

@JerrySentry
Copy link

Yeah #1925 will fix this thing.

@katia-sentry
Copy link
Contributor

Thank you both, I'll close this issue to be fixed in #1925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants