Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steps to new PR comment 100% release (per Q3 2023) #287

Closed
codecovdesign opened this issue Jul 26, 2023 · 4 comments
Closed

Steps to new PR comment 100% release (per Q3 2023) #287

codecovdesign opened this issue Jul 26, 2023 · 4 comments
Assignees
Labels
epic this label is used to mark issues as epics

Comments

@codecovdesign
Copy link
Contributor

codecovdesign commented Jul 26, 2023

Epic outlines steps toward release of new comment, as per the Q3 review

Problem to solve:

We get a lot of feedback that Codecov is noisy/not showing what’s important in both the PR comment and PR page in app. This epic is specifically relevant to the PR comment and the issue of all files being in the same table together, whether you touched them in your PR or not. We’re also looking to move the most important info to the top of the comment (clearly labeled patch and project coverage) as well as ameliorate the lack of indicators around removed code behavior.

Updating the PR comment:

highlight patch and include project coverage up top.

Include line to indicate when removed code behavior comes into play

Put indirect coverage changes minimized in its own section to highlight git diff files first and foremost

Improve routing to land on the specific file in the app that was clicked in the PR Comment

Solution direction and planning

  • layout prioritizing patch
    • block quote with data source and project change
    • small copy change removing by with :
  • showing changed files separate from unexpected indirect changes
    • meets user expectations of "I change X files", previously from "why do I see Y amount?"
    • aligns to information architecture seen in upcoming pulls page
    • reduces cognitive load
  • improves links routing user expects
    • specific file => lands on file expanded in pulls page
    • indirect changed files => lands on respective section in pulls page

Applications team

  1. Link to PR page expands code chunk #295
  2. Make PR comment and in-app consistent data (show coverable files that changed) #286

Other / pre-release

  1. Update pull request documentation images/copy to reflect new comment format #283
  2. New PR comment release blog #284
  3. New PR comment QA review #285
    • challenging to see in production
platform team related issues
@codecovdesign codecovdesign added the epic this label is used to mark issues as epics label Jul 26, 2023
@gambreu
Copy link

gambreu commented Aug 8, 2023

@codecovdesign could you possibly edit the initial comment here to include the documentation you did in the Jira issue (i.e. "Problem to solve", "Design/Solutions", etc): https://codecovio.atlassian.net/browse/CODE-2555

Just want to keep all information in a centralized data location. Thank you!

@katia-sentry katia-sentry transferred this issue from another repository Aug 9, 2023
@codecovdesign
Copy link
Contributor Author

@gambreu updated ✅

@rohan-at-sentry
Copy link

@codecovdesign can you update the description with this task that captures the work to support the new design iteration?

#446

@katia-sentry katia-sentry modified the milestone: Q3'23 Sep 12, 2023
@katia-sentry katia-sentry removed this from the Q3'23 milestone Sep 19, 2023
@aj-codecov aj-codecov moved this from Design Complete to In Progress in Codecov's Roadmap Oct 10, 2023
@codecovdesign
Copy link
Contributor Author

closing epic as all new changes have been made, captured and/or will be completed

@github-project-automation github-project-automation bot moved this from In Progress to Done in Codecov's Roadmap Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic this label is used to mark issues as epics
Projects
Status: Done
Development

No branches or pull requests

5 participants