Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll out new PR comment to 100% of users #675

Closed
Tracked by #132
rohan-at-sentry opened this issue Oct 17, 2023 · 2 comments
Closed
Tracked by #132

Roll out new PR comment to 100% of users #675

rohan-at-sentry opened this issue Oct 17, 2023 · 2 comments
Assignees

Comments

@rohan-at-sentry
Copy link

rohan-at-sentry commented Oct 17, 2023

Given we've rolled out the comments to a subset of users and had positive response, it's a good opportunity to roll this out to 100% of users.

Image

We want to roll out the above comment to 100% of users. Note

  • We'll use the "x lines in your changes are missing coverage. Please review" headline
  • We'll use the comparison section above the "fold"
  • The table with the lines missing with alert icon
  • The diff section is collapsed
  • View full report
  • Feedback

Note

  • The upcoming lite plan does not have the concept of comparison. So the comparison section and the collapsed diff section will not be present in the lite plan
@dana-yaish
Copy link

I want to make sure we're on the same page. So currently we have 3 comment formats released with different percentages to users. Old format is 40%. Patch only comment with little details 10% (left side of this figma design). Patch only comment with more details 50% (right side of the figma design)
And we want the 50% comment to be 100% released, is that correct?

@trent-codecov
Copy link
Contributor

This was completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants