Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Client] - Adjust UsePlanData to Relace 'PlanName' with 'Value' #719

Closed
Tracked by #604
adrian-codecov opened this issue Oct 28, 2023 · 0 comments
Closed
Tracked by #604
Assignees
Labels

Comments

@adrian-codecov
Copy link

adrian-codecov commented Oct 28, 2023

The newest plan hook, usePlanData, has a resolver exposed as planName. We traditionally have treated plan names with the key value instead, and we haven't fully offloaded of it. We're sort of introducing two values, planName and value that represent the same thing, which is hard to keep track of on the frontend. This also stems from most of the backend (excluding gql) only using value instead of planName.

This ticket is to replace every planName with value and adjust the usePlanData hook only to use value (supported on GQL in prod as of now) and get rid of planName until we revise the naming conventions again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant