Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to skip status checks only if > X number of lines has changed #340

Open
vlad-ko opened this issue Apr 19, 2024 · 1 comment
Open
Assignees

Comments

@vlad-ko
Copy link

vlad-ko commented Apr 19, 2024

What product do you want to improve?
Codecov app

Is your feature request related to a problem? Please describe.
One of our largest customers often has tiny PR's (either automated or ad-hoc) that may only contain 5-10 lines of changes. They would prefer to avoid Codecov sending status checks on such PR's because the change is insignificant and the merge is "acceptable".

Describe the solution you'd like
Currently we have a setting that allows to turn of the comment if there are no changes in coverage. https://docs.codecov.com/docs/common-recipe-list#only-comment-on-coverage-changes
require_changes: true
What they would like to see is a configurable value for the status check, possibly alongside the binary switch.
i.e. status_check_if_lines_changed: 10 so if more than ten lines are changed Codecov should send a status check and possibly block the PR, otherwise ignore.

@vlad-ko
Copy link
Author

vlad-ko commented Apr 22, 2024

Additional comments:

Again, the idea is that a PR with 1/2 lines of changes might have 0% of coverage, but is "agreeable" for us to merge. As an example, if I post a PR that touches one file only and adds a log statement, the codecov/patch might notify that we have 0% coverage on this line and block us from merging. Some repositories would rather we just disable the check in this case because the change is small and from their POV, doesn't warrant a test to be added.

A related ask would be for Codecov to provide some bypass feature to allow us to ad-hoc decide when to receive a passing/failing status check on our PR.

@vlad-ko vlad-ko changed the title Allow to send comments only if > X number of lines has changed Allow to skip status checks only if > X number of lines has changed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for: Product Owner
Development

No branches or pull requests

3 participants