Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated codecov checks #474

Open
A5rocks opened this issue Aug 2, 2024 · 4 comments
Open

Duplicated codecov checks #474

A5rocks opened this issue Aug 2, 2024 · 4 comments
Labels
Support For general support questions, e.g. onboarding or configuration Waiting for: Product Owner

Comments

@A5rocks
Copy link

A5rocks commented Aug 2, 2024

Reopening codecov/codecov-action#1022, @thomasrockhu.

In python-trio/trio#3040 for example, you can see a failed check and a successful check for the PR. If you check the commit specifically, there's duplicated versions of the checks but at least they are consistent.

Screenshot:

Image

python-trio/trio#3029 is another that comes from a fork rather than from the same repository (hence doesn't duplicate regular github actions checks)


Edit: just note that we use codecov action v3 so this might be fixed? Though codecov action v4 led to weird coverage drops that were still there so we haven't switched.

@thomasrockhu-codecov thomasrockhu-codecov added the Support For general support questions, e.g. onboarding or configuration label Aug 2, 2024
@thomasrockhu-codecov
Copy link
Contributor

@A5rocks moving this to our feedback repo

@thomasrockhu-codecov thomasrockhu-codecov transferred this issue from codecov/codecov-action Aug 2, 2024
@thomasrockhu-codecov
Copy link
Contributor

@drazisil-codecov do you mind taking a look why we are sending duplicate status checks?

@drazisil-codecov
Copy link

@thomasrockhu-codecov One is a check, the other is a status.

I suspect @A5rocks is seeing this bug codecov/engineering-team#1967

@A5rocks
Copy link
Author

A5rocks commented Aug 5, 2024

That seems very likely! python-trio/trio#3051 is another PR that hit this just in case it helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support For general support questions, e.g. onboarding or configuration Waiting for: Product Owner
Projects
Status: Waiting for: Product Owner
Development

No branches or pull requests

3 participants