feat(stage): rename shouldShowNeedHelpForumLink to shouldShowStage1ForumLinkCTA and update its logic

andy1li · andy1li · commit 4071e9d314e9 · 2024-12-28T05:40:45.000+08:00
Updated the name of the `shouldShowNeedHelpForumLink` property to `shouldShowStage1ForumLinkCTA` and modified its logic to align with its new name.
diff --git a/app/controllers/course/stage/instructions.ts b/app/controllers/course/stage/instructions.ts
@@ -55,14 +55,14 @@ export default class CourseStageInstructionsController extends Controller {
     return !this.currentStep.courseStage.isFirst && this.currentStep.status === 'complete';
   }
 
-  get shouldShowNeedHelpForumLink() {
-    return this.model.courseStage.isFirst && this.currentStep.testsStatus !== 'passed' && this.currentStep.status !== 'complete';
-  }
-
   get shouldShowPrerequisites() {
     return !!this.prerequisiteInstructionsMarkdown;
   }
 
+  get shouldShowStage1ForumLinkCTA() {
+    return this.model.courseStage.isFirst && this.currentStep.testsStatus !== 'passed' && this.currentStep.status !== 'complete';
+  }
+
   get shouldShowTestRunnerCard() {
     return this.isCurrentStage && this.currentStep.status !== 'complete';
   }
diff --git a/app/templates/course/stage/instructions.hbs b/app/templates/course/stage/instructions.hbs
@@ -83,7 +83,7 @@
       </div>
     {{/if}}
 
-    {{#if this.shouldShowNeedHelpForumLink}}
+    {{#if this.shouldShowStage1ForumLinkCTA}}
       <div class="prose dark:prose-invert prose-sm prose-compact ml-4 mb-10">
         <p>
           Need help?

Original file line number	Diff line number	Diff line change
`@@ -55,14 +55,14 @@ export default class CourseStageInstructionsController extends Controller {`
`55`	`55`	`return !this.currentStep.courseStage.isFirst && this.currentStep.status === 'complete';`
`56`	`56`	`}`
`57`	`57`
`58`		`- get shouldShowNeedHelpForumLink() {`
`59`		`- return this.model.courseStage.isFirst && this.currentStep.testsStatus !== 'passed' && this.currentStep.status !== 'complete';`
`60`		`- }`
`61`		`-`
`62`	`58`	`get shouldShowPrerequisites() {`
`63`	`59`	`return !!this.prerequisiteInstructionsMarkdown;`
`64`	`60`	`}`
`65`	`61`
	`62`	`+ get shouldShowStage1ForumLinkCTA() {`
	`63`	`+ return this.model.courseStage.isFirst && this.currentStep.testsStatus !== 'passed' && this.currentStep.status !== 'complete';`
	`64`	`+ }`
	`65`	`+`
`66`	`66`	`get shouldShowTestRunnerCard() {`
`67`	`67`	`return this.isCurrentStage && this.currentStep.status !== 'complete';`
`68`	`68`	`}`