Add dobs support for VolumeInspectByName #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch add the VolumeInspectByName function to the dobs driver, allowing a caller to more efficiently retrieve a single volume when doing a lookup by name instead of by ID. When looking up a volume by name instead of ID, the DO API requires a region, so the way a region was looked up was changed to have commonality between VolumeCreate() and VolumeInspectByName(). VolumeCreate() retains the additional capability to read a region from the AvailabilityZone create option. The order of precedence for region is: 1. az op (create only) 2. IID header field 3. driver config
Codecov Report
@@ Coverage Diff @@
## master #581 +/- ##
=======================================
Coverage 28.42% 28.42%
=======================================
Files 34 34
Lines 2016 2016
=======================================
Hits 573 573
Misses 1381 1381
Partials 62 62Continue to review full report at Codecov.
|
akutz
approved these changes
Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add the VolumeInspectByName function to the dobs driver,
allowing a caller to more efficiently retrieve a single volume when
doing a lookup by name instead of by ID.
When looking up a volume by name instead of ID, the DO API requires a
region, so the way a region was looked up was changed to have
commonality between VolumeCreate() and VolumeInspectByName().
VolumeCreate() retains the additional capability to read a region from
the AvailabilityZone create option.
The order of precedence for region is: