Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meetup API errors #312

Open
tdooner opened this issue Dec 8, 2017 · 1 comment
Open

Meetup API errors #312

tdooner opened this issue Dec 8, 2017 · 1 comment

Comments

@tdooner
Copy link

tdooner commented Dec 8, 2017

it appears that sometimes the meetup API returns an error, and it crashes the updating process.

INFO:root:Gathering all of Code for Tulsa's events.
Traceback (most recent call last):
  File "run_update.py", line 1380, in <module>
    main(org_name=org_name, org_sources=org_sources)
  File "run_update.py", line 1314, in main
    members = get_meetup_count(organization, identifier)
  File "run_update.py", line 179, in get_meetup_count
    response = got.json()
  File "/app/.heroku/python/lib/python2.7/site-packages/requests/models.py", line 805, in json
    return complexjson.loads(self.text, **kwargs)
  File "/app/.heroku/python/lib/python2.7/json/__init__.py", line 338, in loads
    return _default_decoder.decode(s)
  File "/app/.heroku/python/lib/python2.7/json/decoder.py", line 365, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/app/.heroku/python/lib/python2.7/json/decoder.py", line 383, in raw_decode
    raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded

We should

  1. be conscious of any meetup rate limits
  2. handle errors without crashing the run
  3. log a useful error message when this breaks
@strixcuriosus
Copy link

It looks like #2 (handle errors without crashing the run) was already fixed in this pull request: #318

logging and/or some retry logic may still be helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants