Volunteer Section #144
Merged
Volunteer Section #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheshireoctopus
commented
Jul 22, 2020
| @@ -2,6 +2,22 @@ | |||
|
|
|||
| footer { | |||
| color: $navy; | |||
|
|
|||
There was a problem hiding this comment.
Had to scope these styles within footer as they were impacting global scope.
Realizing now this file is indented with tabs while the other .scss files are indented with spaces. Should I use this PR to change the indentation here?
There was a problem hiding this comment.
I think added this change on this PR will be fine. I will send back with this request.
cheshireoctopus
commented
Jul 22, 2020
| @@ -131,6 +131,22 @@ p { | |||
| color: $navy; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Okay to add these styles to the global scope?
Here is how the a renders:
and here is how .button-link renders:
There was a problem hiding this comment.
Yes, adding that style to the global scope is perfect.
rhyn0bytes
approved these changes
Aug 4, 2020
| @@ -131,6 +131,22 @@ p { | |||
| color: $navy; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Yes, adding that style to the global scope is perfect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements the "Volunteer" section of the CFD website as described in the Figma for desktop and mobile :