Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Durham API import #141

Open
copelco opened this issue Jul 1, 2014 · 3 comments
Open

Test Durham API import #141

copelco opened this issue Jul 1, 2014 · 3 comments
Milestone

Comments

@copelco
Copy link
Member

copelco commented Jul 1, 2014

Primarily the forms. We want to make sure we only update the intended fields, e.g. not replace property_id.

@copelco copelco added this to the Phase 3 milestone Jul 1, 2014
@copelco
Copy link
Member Author

copelco commented Jul 1, 2014

Or, for example, what if we fix the lat/lng coordinates in the admin. On the next import, we should probably skip importing the location.

@tamcap
Copy link
Contributor

tamcap commented Jul 1, 2014

Would it make more sense to just have a list of fields we want to overwrite? I.e. we assume our db takes precedence over the Durham one, unless it's a change of address.

@copelco
Copy link
Member Author

copelco commented Jul 1, 2014

I think it depends on how the form is implemented, but yes. Establishments use the exclude meta property. In the end, I want a regression test to fail if we add a new field and it gets overwritten (as in, we forget to add it to exclude).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants