-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not really ORM-Agnostic #75
Comments
@TiagoCardoso1983 are you correctly including ActiveModel::Validations? http://api.rubyonrails.org/classes/ActiveModel/Validator.html |
sequel has its own validations plugin, and therefore doesn't use activemodel validations. If this gem requires them, then it is neither ORM-agnostic nor Rails-agnostic. Am I correct inferring this? Because if so, you could at least update the "ORM-agnostic" disclaimer in the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This gem doesn't work for Sequel, not outside of the box at least. The EachValidator object is AFAIK only defined in Rails, and is not part of the ActiveModel spec.
One could remove the ORM-agnostic description (unless there's morethan ActiveRecord this gem supports) or build a validation method to be added to Sequel::Model when loading the ValidationHelpers plugin.
The text was updated successfully, but these errors were encountered: