Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More 'undefined' vars checks #17

Closed
yeeplusplus opened this issue Jul 26, 2019 · 3 comments · May be fixed by #18
Closed

More 'undefined' vars checks #17

yeeplusplus opened this issue Jul 26, 2019 · 3 comments · May be fixed by #18
Milestone

Comments

@yeeplusplus
Copy link
Contributor

There are three more instances where undefined variables aren't checked in a way that works with the nounset flag

Example (dummy_test):

testDummy() {
  set -o nounset
  cleanupSpies
}

Output:

# dummy_test: 147: eval: _shpy_spies_dir: parameter not set

The other two instances involve createSpy: if a return value is passed via -r, and if no spy name is passed

@codehearts
Copy link
Owner

I think the remaining undefined variables have been weeded out, is it alright if I close this or do you want to take a second look at this?

@codehearts codehearts added this to the v1.0.0 milestone Aug 25, 2019
@yeeplusplus
Copy link
Contributor Author

You can close it. Sorry I haven't been as available as I thought I would be.

@codehearts
Copy link
Owner

It's ok, I really appreciate your contributions and I'm sorry for trampling over your last PR! You actually revealed that shpy wasn't working under some of the shells it claimed to support, and it's motivated me to pay more attention to this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants