Commit 6f70eca
committed
refactor: fix TypeError in Postgre/Builder.php
There were 2 errors:
1) CodeIgniter\Database\Live\UpsertTest::testUpsertWithMatchingDataOnUniqueIndexandPrimaryKey
TypeError: strtoupper(): Argument #1 ($string) must be of type string, int given
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/Postgre/Builder.php:364
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/BaseBuilder.php:1790
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/BaseBuilder.php:1927
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Database/Live/UpsertTest.php:410
2) CodeIgniter\Database\Live\UpsertTest::testUpsertBatchOnPrimaryKey
TypeError: strtoupper(): Argument #1 ($string) must be of type string, int given
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/Postgre/Builder.php:364
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/BaseBuilder.php:1790
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/BaseBuilder.php:1961
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Database/Live/UpsertTest.php:457
--
There was 1 failure:
1) CodeIgniter\Database\Live\UpsertTest::testUpsertCauseConstraintError
Failed asserting that exception of type "TypeError" matches expected exception "CodeIgniter\Database\Exceptions\DatabaseException". Message was: "trim(): Argument #1 ($string) must be of type string, CodeIgniter\Database\RawSql given" at
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/Postgre/Builder.php:360
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/BaseBuilder.php:1790
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Database/BaseBuilder.php:1927
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Database/Live/UpsertTest.php:3031 parent b7deefa commit 6f70eca
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
355 | 355 | | |
356 | 356 | | |
357 | 357 | | |
358 | | - | |
| 358 | + | |
359 | 359 | | |
360 | 360 | | |
361 | 361 | | |
362 | | - | |
| 362 | + | |
363 | 363 | | |
364 | 364 | | |
365 | 365 | | |
| |||
0 commit comments