-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit testing broken in travis-ci #1003
Comments
I think it's just that my exceptions branch is still throwing lots of errors. Develop branch seems fine. |
Hmmm - PR 993, where things first started to go south, seems to be the develop branch to me. :-/ |
Oh, I see what you mean now. Well - I just got all of the tests for my exceptions branch working, so I'll be merging that here shortly and we'll see what it looks like after that. I know I fixed a stray |
Yup. that seemed to fix everything. Closing this. |
Er, it didn't fix everything. |
Strange that doesn't show up locally or on Travis. :( Renaming that class to simply Error is fine, and as it should be. |
Several things have happened over the last 8 PR merges or so, breaking travis-ci. The unit tests are failing, but travis-ci is reporting "success".
PR 981 passed (1836 tests)
PR 984 LoggerTest failed (1 of 1837 tests) - not changed in this PR
PR 986 no change
PR 990 no change, except for more Javascript in front of tests
PR 993 travis-ci "breaks"
PR 995 travis-ci "breaks" more
PR 996 no change
PR 998 no change
The text was updated successfully, but these errors were encountered: