Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A suggestion for debug exceptions layout #295

Closed
sayonara90s opened this issue Oct 17, 2016 · 3 comments
Closed

A suggestion for debug exceptions layout #295

sayonara90s opened this issue Oct 17, 2016 · 3 comments

Comments

@sayonara90s
Copy link
Contributor

I think using modal with maximum CSS z-index can fix broken the layout like this:
CodeIgniter4 sample

And this is an example with bootstrap I made:
Custom sample

or one button for show and hide the error screen.

Just a little idea.

Thank you Sir, for your fast response!

@lonnieezell
Copy link
Member

The styles used should be constrained to the page itself, though we might be able to tie that down a little more. That said, I've never seen the layout do that before. We can't necessarily do modals because every front-end framework is different, and we don't need to pull an entire framework in just to handle a debug page.

Do you have any idea what was causing the layout issue to begin with?

@sayonara90s
Copy link
Contributor Author

I don't have, because an error layout (segment) is different with debug bar.
An error layout maight be wrapped by other (parent) tag/layout element.

<pre><!-- or other element with style -->
    <div id="errorDiv">error layout</div>
</pre>

The advantages of using modal, we can find or showing en error slightest that not detected by user/developer.

@lonnieezell
Copy link
Member

Closing this one for now. While modals are definitely an interesting solution, I can see them being more problematic as people start to integrate into their projects.

I have made changes in the past to help with this, though, including clearing the output buffer when an exception happens and a couple of other small tweaks. I think we're good here.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants