Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Registrars take priority over .env #3845

Closed
MGatner opened this issue Nov 1, 2020 · 0 comments · Fixed by #4659
Closed

Bug: Registrars take priority over .env #3845

MGatner opened this issue Nov 1, 2020 · 0 comments · Fixed by #4659
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@MGatner
Copy link
Member

MGatner commented Nov 1, 2020

Registrar values should still be overridden when there is an equivalent .env property. The issue is with the ordering of property handling in BaseConfig's constructor:

CodeIgniter4/system/Config/BaseConfig.php

Line 60 in 3411b68

public function __construct()

@MGatner MGatner added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 1, 2020
@MGatner MGatner mentioned this issue May 9, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Registrar and .env priority MGatner/CodeIgniter4
1 participant
@MGatner