Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: spark routes show error when using custom placeholder (regex) #6276

Closed
totoprayogo1916 opened this issue Jul 19, 2022 · 1 comment · Fixed by #6279
Closed

Bug: spark routes show error when using custom placeholder (regex) #6276

totoprayogo1916 opened this issue Jul 19, 2022 · 1 comment · Fixed by #6279
Assignees
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@totoprayogo1916
Copy link
Contributor

PHP Version

7.4

CodeIgniter4 Version

4.2.1

CodeIgniter4 Installation Method

Manual (zip or tar.gz)

Which operating systems have you tested for this bug?

Windows

Which server did you use?

cli-server (PHP built-in webserver)

Database

MariaDB

What happened?

when run php spark routes
show 404 error like:
image

Steps to Reproduce

add route

// app/Config/Routes.php
$routes->get('detail/([a-z0-9]{40})', 'User::detail/$1');
// or add using custom placeholder

$routes->addPlaceholder('uid', '[a-z0-9]{40}');
$routes->get('detail/(:uid)', 'User::detail/$1');

then run

php spark routes

Expected Output

show route lists as expected

Anything else?

No response

@totoprayogo1916 totoprayogo1916 added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 19, 2022
@totoprayogo1916 totoprayogo1916 changed the title Bug: Spark routes show error when using custom placeholder (regex) Bug: spark routes show error when using custom placeholder (regex) Jul 19, 2022
@kenjis kenjis self-assigned this Jul 19, 2022
@kenjis
Copy link
Member

kenjis commented Jul 19, 2022

Thanks for reporting.
I sent a PR #6279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants