Bug: Validation on null for trim

[ValdisM]

PHP Version

8.1

CodeIgniter4 Version

4.2.5

CodeIgniter4 Installation Method

Composer (using codeigniter4/appstarter)

Which operating systems have you tested for this bug?

macOS

Which server did you use?

apache

Database

No response

What happened?

trim() on null is not working for validation.

I suggest to edit: Validation.php Line 302:

$passed = $param === false ? $rule((string) $value ?? '') : $rule((string) $value ?? '', $param, $data);

Steps to Reproduce

make rule without a post.

Expected Output

Expected:\

Previous:
$passed = $param === false ? $rule($value) : $rule($value, $param, $data);

$passed = $param === false ? $rule((string) $value ?? '') : $rule((string) $value ?? '', $param, $data);

Anything else?

No response

[kenjis]

Sorry, I don't get what you say. Why do you use trim()?
Validation never alters input data.

Can you show exact Steps to Reproduce?

[kenjis]

If you still think this is a bug, feel free to reopen.

[pietos]

I have the same issue, when you post an empty value on a form validation where you specified trim it results into:

"message": "trim(): Passing null to parameter #1 ($string) of type string is deprecated",
"file": "C:\docker_xampp\htdocs\slurpee_portal\system\Validation\Validation.php",

[kenjis]

If you specify trim in the validation rules, the Validation does not trim the value.
Why do you need to specify trim ?

[pietos]

Well, the problem is not trim but the function:
permit_empty

in the permit empty they do a trim on the value to see if it's really "", but when the value is NULL this results into this error.

system\Validation\Validation.php

[kenjis]

Cannot reproduce.
If you can reproduce the error, please create an issue with minimum code to reproduce.

php > echo trim(null);
PHP Deprecated:  trim(): Passing null to parameter #1 ($string) of type string is deprecated in php shell code on line 1
PHP Stack trace:
PHP   1. {main}() php shell code:0
PHP   2. trim($string = NULL) php shell code:1

php > echo trim((string) null);
php >